windows: add missing include for mingw32 #348

Merged

selsta merged 1 commit from windows-include into master

2021-11-10 17:00:26 -06:00

selsta commented

2021-11-09 20:14:45 -06:00

(Migrated from github.com)

Seems to be introduced in https://github.com/libusb/hidapi/pull/309/

2021-11-10T00:31:43.7352733Z hid.c:164:83: error: unknown type name ‘DEVPROPKEY’
2021-11-10T00:31:43.7355003Z   typedef CONFIGRET(__stdcall* CM_Get_DevNode_PropertyW_)(DEVINST dnDevInst, CONST DEVPROPKEY* PropertyKey, DEVPROPTYPE* PropertyType, PBYTE PropertyBuffer, PULONG PropertyBufferSize, ULONG ulFlags);

Seems to be introduced in https://github.com/libusb/hidapi/pull/309/ ``` 2021-11-10T00:31:43.7352733Z hid.c:164:83: error: unknown type name ‘DEVPROPKEY’ 2021-11-10T00:31:43.7355003Z typedef CONFIGRET(__stdcall* CM_Get_DevNode_PropertyW_)(DEVINST dnDevInst, CONST DEVPROPKEY* PropertyKey, DEVPROPTYPE* PropertyType, PBYTE PropertyBuffer, PULONG PropertyBufferSize, ULONG ulFlags); ```

Youw commented

2021-11-10 04:43:11 -06:00

(Migrated from github.com)

Could you confirm that the header name as provided by MinGW is exactlty devpropdef.h? And not Devpropdef.h (First letter caseness, it is upper-case in Windows SDK)?
Otherwise , if it doesn't match, it will fail during cross-compilation from Linux.

Could you confirm that the header name as provided by MinGW is exactlty `devpropdef.h`? And not `Devpropdef.h` (First letter caseness, it is upper-case in Windows SDK)? Otherwise , if it doesn't match, it will fail during cross-compilation from Linux.

selsta commented

2021-11-10 15:39:11 -06:00

(Migrated from github.com)

lrwxrwxrwx  1 root root    42 Nov 15  2019 devpropdef.h -> ../../share/mingw-w64/include/devpropdef.h

Seems to be devpropdef.h, though I have seen the capitalized spelling here: https://docs.microsoft.com/en-us/previous-versions/ff543546(v=vs.85)

Otherwise , if it doesn't match, it will fail during cross-compilation from Linux.

Cross compiling from Linux is how I triggered this issue in the first place (https://github.com/monero-project/monero/pull/8055), with the patch applied it compiled fine.

``` lrwxrwxrwx 1 root root 42 Nov 15 2019 devpropdef.h -> ../../share/mingw-w64/include/devpropdef.h ``` Seems to be `devpropdef.h`, though I have seen the capitalized spelling here: https://docs.microsoft.com/en-us/previous-versions/ff543546(v=vs.85) > Otherwise , if it doesn't match, it will fail during cross-compilation from Linux. Cross compiling from Linux is how I triggered this issue in the first place (https://github.com/monero-project/monero/pull/8055), with the patch applied it compiled fine.

Youw (Migrated from github.com) approved these changes

2021-11-10 17:00:01 -06:00

Youw (Migrated from github.com) left a comment