gh-libusb/hidapi
Watch
1
0
Fork
You've already forked hidapi
 0
Code Issues 58 Pull requests 18 Releases 13 Wiki Activity

Add Windows-specific API to get device container ID #379

Merged
triplef merged 3 commits from windows-container-id into master 2022-02-25 02:53:00 -06:00
Conversation 3 Commits 3 Files changed 3 +94
triplef commented 2022-02-09 05:47:12 -06:00 (Migrated from github.com)

As discussed in https://github.com/libusb/hidapi/discussions/252#discussioncomment-2089707.

As discussed in https://github.com/libusb/hidapi/discussions/252#discussioncomment-2089707.
Youw (Migrated from github.com) reviewed 2022-02-09 06:46:33 -06:00
Youw (Migrated from github.com) left a comment

Looks good

Looks good
windows/hid.c
@ -1048,6 +1048,44 @@ int HID_API_EXPORT_CALL HID_API_CALL hid_get_indexed_string(hid_device *dev, int
return 0;
Youw (Migrated from github.com) commented 2022-02-09 06:45:22 -06:00

call CM_Get_DevNode_PropertyW directly and pass guid - you'll avoid extra memory allocation/copy/free

call `CM_Get_DevNode_PropertyW` directly and pass `guid` - you'll avoid extra memory allocation/copy/free
windows/hidapi_winapi.h
@ -0,0 +1,54 @@
/*******************************************************
Youw (Migrated from github.com) commented 2022-02-09 06:32:02 -06:00 
		int HID_API_EXPORT_CALL hid_winapi_get_container_id(hid_device *dev, GUID *container_id);
```suggestion int HID_API_EXPORT_CALL hid_winapi_get_container_id(hid_device *dev, GUID *container_id); ```
windows/hidapi_winapi.h
@ -0,0 +32,4 @@
extern "C" {
#endif
/** @brief Get the container ID for a HID device.
Youw (Migrated from github.com) commented 2022-02-09 06:46:27 -06:00

Add mode description/details. Make a reference to DEVPKEY_Device_ContainerId

Add mode description/details. Make a reference to `DEVPKEY_Device_ContainerId`
windows/hidapi_winapi.h
@ -0,0 +40,4 @@
@ingroup API
@param dev A device handle returned from hid_open().
@param guid The device's container ID on return.
Youw (Migrated from github.com) commented 2022-02-09 06:31:51 -06:00 
			@param guid The device's container ID on return.

			@note Make sure to include `<Windows.h>` before including `hidapi_winapi.h`.
```suggestion @param guid The device's container ID on return. @note Make sure to include `<Windows.h>` before including `hidapi_winapi.h`. ```
triplef (Migrated from github.com) reviewed 2022-02-10 06:08:29 -06:00
windows/hidapi_winapi.h
@ -0,0 +40,4 @@
@ingroup API
@param dev A device handle returned from hid_open().
@param guid The device's container ID on return.
triplef (Migrated from github.com) commented 2022-02-10 06:08:29 -06:00

I included guiddef.h, which is all that should be needed to include hidapi_winapi.h.

I included `guiddef.h`, which is all that should be needed to include `hidapi_winapi.h`.
Youw (Migrated from github.com) approved these changes 2022-02-10 07:10:10 -06:00
Sign in to join this conversation.
Reviewers
No reviewers
Youw
Labels
Clear labels   
3rdparty
3rd-party related issue/question

  
Android
Android OS related

  
API
API change, Version 1 stuff

  
Author does not respond

   
bsd
FreeBSD, NetBSD, OpenBSD, etc

  
bug
Something isn't working

  
build system/CI
Anything related to building the project or running on CI

  
ci-virtual-device
Run the virtual HID device CI jobs (Windows driver + libusb raw-gadget)

  
CMake
Related to CMake build system

  
Contributions Welcome
Any external help is welcome

  
Core
Related to common codes like hidapi.h

  
dependencies
Pull requests that update a dependency file

  
device-specific
Issues/PRs related to a specific device

  
documentation
Improvements or additions to documentation

  
don't_merge
Don't merge this PR as is

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
Example
Related to hidtest or new examples

  
Haiku
Related to Haiku OS (using libusb backend)

  
hidraw
Related to Linux/hidraw backend

  
hotplug
Related to hotplug

  
info required
Need more input from PR/issue author

  
invalid
Not a HIDAPI issue

  
libusb
Related to libusb backend

  
macOS
Related to macOS backend

  
Misc
Typo, whitespace, etc.

  
Not an issue

   
question
Information is requested

  
Release
Related to new release

  
Test
Related to built-in test (not hidtest)

  
Test GUI
Related to a Test GUI application

  
Windows
Related to Windows backend

  
wontfix
This will not be worked on

No labels
3rdparty
Android
API
Author does not respond
bsd
bug
build system/CI
ci-virtual-device
CMake
Contributions Welcome
Core
dependencies
device-specific
documentation
don't_merge
duplicate
enhancement
Example
Haiku
hidraw
hotplug
info required
invalid
libusb
macOS
Misc
Not an issue
question
Release
Test
Test GUI
Windows
wontfix
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-libusb/hidapi!379
No description provided.