Fix find_package(hidapi) warnings #404

Merged

Youw merged 1 commit from cmake-export-fixes into master

2022-05-02 06:09:16 -05:00

Youw commented

2022-04-25 10:21:14 -05:00

(Migrated from github.com)

FindPkgConfig.cmake warns it is not called by find_package;
CMake package config file and exports file names should not match,
otherwise it gets included recursively by GLOB expression;

- FindPkgConfig.cmake warns it is not called by find_package; - CMake package `config` file and `exports` file names should not match, otherwise it gets included recursively by GLOB expression;

stsichler commented

2022-11-16 08:12:24 -06:00

(Migrated from github.com)

this commit seems to break detection of find_package() of specific versions, see #482

this commit seems to break detection of `find_package()` of specific versions, see #482

Youw commented

2022-11-16 09:11:26 -06:00

(Migrated from github.com)

Looks like so.
We need a CI check for scenario described in #482.
Thanks for finding it.

Any chance you could provide a PR with the fix?

Looks like so. We need a CI check for scenario described in #482. Thanks for finding it. Any chance you could provide a PR with the fix?

Youw commented

2022-11-16 09:26:22 -06:00

(Migrated from github.com)

Ah, I specifically renamed the hidapi-config-version into libhidapi-version.
Not sure what was the reason for that.
It might be accidentally or I was trying to fix some of the warnings.
Would need to check.

Ah, I specifically renamed the `hidapi-config-version` into `libhidapi-version`. Not sure what was the reason for that. It might be accidentally or I was trying to fix some of the warnings. Would need to check.