windows: Get Bluetooth device Model Number String instead of Device Name into product string #500

2023-01-27T07:48:53-06:00

DJm00n commented

2023-01-27 07:48:53 -06:00

(Migrated from github.com)

Use Device Name only if Model Number String is not available. This should better match what we have in USB_DEVICE_DESCRIPTOR.iProduct

See Bluetooth Device Information Service spec for more info.

Use `Device Name` only if `Model Number String` is not available. This should better match what we have in `USB_DEVICE_DESCRIPTOR.iProduct` See [Bluetooth Device Information Service](https://www.bluetooth.com/specifications/specs/device-information-service-1-1/) spec for more info.

Youw (Migrated from github.com) reviewed

2023-02-01 12:50:02 -06:00

windows/hid.c

					
				@ -409,32 +409,46 @@ static void* hid_internal_get_device_interface_property(const wchar_t* interface

					return property_value;

I'm not a fan of this early return here
let's avoid it and have the read of DEVPKEY_NAME under an if

I'm not a fan of this early return here let's avoid it and have the read of `DEVPKEY_NAME` under an `if`

Youw (Migrated from github.com) reviewed

2023-02-01 12:50:15 -06:00

Youw (Migrated from github.com) left a comment

No more comments, thanks

Youw (Migrated from github.com) approved these changes

2023-03-12 07:36:49 -05:00

Youw (Migrated from github.com) left a comment

@DJm00n please check if I accidentally didn't break anything. I don't have an actual BLE device to check this.

DJm00n commented

2023-03-12 13:55:01 -05:00

(Migrated from github.com)

@Youw looks good. thanks

Sign in to join this conversation.

No reviewers

Youw

No labels

3rdparty

Android

API

Author does not respond

Contributions Welcome

No milestone

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

gh-libusb/hidapi!500

				`@ -409,32 +409,46 @@ static void* hid_internal_get_device_interface_property(const wchar_t* interface`
				`return property_value;`

Rows
Columns