gh-libusb/hidapi

Watch

windows: Have a separate definition flag for export #515

Merged

Youw merged 1 commit from dev-win-static into master

2023-03-13 05:11:38 -05:00

Youw commented

2023-03-12 07:24:24 -05:00

(Migrated from github.com)

On some compilers an empty definition (e.g. -DHID_API_EXPORT) means the same as =1 (e.g. -DHID_API_EXPORT=1), but the HID_API_EXPORT macro should be empty in static library build case.

Having a separate compiler definition flag solves that issue.

Closes: #512
Relates: #480

On some compilers an empty definition (e.g. -DHID_API_EXPORT) means the same as =1 (e.g. -DHID_API_EXPORT=1), but the HID_API_EXPORT macro should be empty in static library build case. Having a separate compiler definition flag solves that issue. Closes: #512 Relates: #480

Youw commented

2023-03-12 07:25:52 -05:00

(Migrated from github.com)

@SamuelC0507 this should fix the issue you've faced.

@SamuelC0507 this should fix the issue you've faced.

SamuelC0507 commented

2023-03-12 22:28:15 -05:00

(Migrated from github.com)

@SamuelC0507 this should fix the issue you've faced.

Just tried it and yes indeed it does, thanks!

> @SamuelC0507 this should fix the issue you've faced. Just tried it and yes indeed it does, thanks!

Sign in to join this conversation.

No reviewers

No labels

Author does not respond

build system/CI

ci-virtual-device

Contributions Welcome

device-specific

No milestone

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

gh-libusb/hidapi!515

No description provided.