Suggestion for new windows import/export macro handling #520

Closed

OgreTransporter wants to merge 2 commits from master into master

OgreTransporter commented

2023-03-27 06:30:04 -05:00

(Migrated from github.com)

#480

Youw commented

2023-03-27 07:53:18 -05:00

(Migrated from github.com)

I understand this is a "step into a right direction", but what does it fix here?
The fact that you need to modify the Makefiles and MSVC project - means the changes breaks the build for those who desided to embedde HIDAPI directly as a source (as was originally advertized by the HIDAPI author) - sample.
It is not a big deal to fix it, e.g. for cython-hidapi, but that is exactly a maintenance burden I'd like to avoid completely until v1.0.

I understand this is a "step into a right direction", but what does it fix here? The fact that you need to modify the Makefiles and MSVC project - means the changes breaks the build for those who desided to embedde HIDAPI directly as a source (as was originally advertized by the HIDAPI author) - [sample](https://github.com/trezor/cython-hidapi/blob/8e92053d0d7f5a5dd9bdfeb6a78191ef717cdccf/setup.py). It is not a big deal to fix it, e.g. for cython-hidapi, but that is exactly a maintenance burden I'd like to avoid completely until v1.0.

OgreTransporter commented

2023-03-27 08:10:25 -05:00

(Migrated from github.com)