gh-libusb/hidapi
Watch
1
0
Fork
You've already forked hidapi
 0
Code Issues 58 Pull requests 18 Releases 13 Wiki Activity

hidapi/libusb: enable support for Xbox 360 and Xbox One controllers #572

Merged
slouken merged 2 commits from 0001-hidapi-libusb-enable-support-for-Xbox-360-and-Xbox-O.patch into master 2023-07-23 04:57:49 -05:00
Conversation 16 Commits 2 Files changed 1 +180 -6
slouken commented 2023-05-26 11:07:27 -05:00 (Migrated from github.com)

Xbox controllers are not technically HID devices, but you can talk to them directly using libusb, and SDL uses this to talk to controllers which may not have OS-level support.

Xbox controllers are not technically HID devices, but you can talk to them directly using libusb, and [SDL](https://github.com/libsdl-org/SDL) uses this to talk to controllers which may not have OS-level support.
slouken commented 2023-05-26 22:32:38 -05:00 (Migrated from github.com)

This pull request depends on https://github.com/libusb/hidapi/pull/568, which must be merged before this will pass.

This pull request depends on https://github.com/libusb/hidapi/pull/568, which must be merged before this will pass.
mcuee commented 2023-05-26 22:59:59 -05:00 (Migrated from github.com)

@slouken

There are warnings treated as errors so that ubuntu-cmake github action failed. Please help to fix. Thanks.

@slouken There are warnings treated as errors so that ubuntu-cmake github action failed. Please help to fix. Thanks.
slouken commented 2023-05-26 23:07:16 -05:00 (Migrated from github.com)

I fixed the warnings, and I'll squash the PR once the build passes. There's still one error left that requires #568 to be merged first.

I fixed the warnings, and I'll squash the PR once the build passes. There's still one error left that requires #568 to be merged first.
👍 1
slouken commented 2023-05-26 23:20:02 -05:00 (Migrated from github.com)

All ready to go!

All ready to go!
Youw (Migrated from github.com) reviewed 2023-05-31 11:46:12 -05:00
libusb/hid.c
@ -678,0 +736,4 @@
0x10f5, /* Turtle Beach */
0x1532, /* Razer Wildcat */
0x20d6, /* PowerA */
0x24c6, /* PowerA */
Youw (Migrated from github.com) commented 2023-05-31 11:46:12 -05:00

looks like some debug code
remove?

looks like some debug code remove?
Youw (Migrated from github.com) reviewed 2023-05-31 11:48:22 -05:00
libusb/hid.c
@ -987,0 +1139,4 @@
if (res < 0) {
LOG("xbox init: can't set alt setting %d: %d\n", intf_desc->bInterfaceNumber, res);
}
Youw (Migrated from github.com) commented 2023-05-31 11:48:21 -05:00

zero-initialize the data
otherwise, libusb_control_transfer may try to read it, which is undefined behavior

zero-initialize the `data` otherwise, `libusb_control_transfer` may try to read it, which is undefined behavior
Youw (Migrated from github.com) reviewed 2023-05-31 11:50:24 -05:00
libusb/hid.c
@ -678,0 +736,4 @@
0x10f5, /* Turtle Beach */
0x1532, /* Razer Wildcat */
0x20d6, /* PowerA */
0x24c6, /* PowerA */
Youw (Migrated from github.com) commented 2023-05-31 11:50:24 -05:00

please don't use UPPER_SNAKE_CASE for named constants - it is generally error-prone in C/C++ due to fact that usually it is used for macros

here and elsewhere

please don't use `UPPER_SNAKE_CASE` for named constants - it is generally error-prone in C/C++ due to fact that usually it is used for macros here and elsewhere
Youw (Migrated from github.com) reviewed 2023-05-31 11:51:49 -05:00
libusb/hid.c
@ -987,0 +1139,4 @@
if (res < 0) {
LOG("xbox init: can't set alt setting %d: %d\n", intf_desc->bInterfaceNumber, res);
}
Youw (Migrated from github.com) commented 2023-05-31 11:51:49 -05:00

I'm pretty sure if we're passing the libusb_config_descriptor *conf_desc - int config_number is redundant
lets omit it

I'm pretty sure if we're passing the `libusb_config_descriptor *conf_desc` - `int config_number` is redundant lets omit it
Youw commented 2023-05-31 11:53:45 -05:00 (Migrated from github.com)

Does SDL users ever use hidraw backend on Linux for devices like this?

Does SDL users ever use hidraw backend on Linux for devices like this?
slouken (Migrated from github.com) reviewed 2023-05-31 12:03:19 -05:00
libusb/hid.c
@ -678,0 +736,4 @@
0x10f5, /* Turtle Beach */
0x1532, /* Razer Wildcat */
0x20d6, /* PowerA */
0x24c6, /* PowerA */
slouken (Migrated from github.com) commented 2023-05-31 12:03:19 -05:00

I uncomment this frequently for debugging purposes. I can remove it from this PR if you like.

I uncomment this frequently for debugging purposes. I can remove it from this PR if you like.
slouken commented 2023-05-31 12:04:06 -05:00 (Migrated from github.com)

Does SDL users ever use hidraw backend on Linux for devices like this?

No, hidraw doesn't expose Xbox controllers.

> Does SDL users ever use hidraw backend on Linux for devices like this? No, hidraw doesn't expose Xbox controllers.
Youw (Migrated from github.com) reviewed 2023-05-31 12:22:10 -05:00
libusb/hid.c
@ -678,0 +736,4 @@
0x10f5, /* Turtle Beach */
0x1532, /* Razer Wildcat */
0x20d6, /* PowerA */
0x24c6, /* PowerA */
Youw (Migrated from github.com) commented 2023-05-31 12:22:10 -05:00

at least make it a /* C comment */ (our code-style agreement)
or hide it under #if 0

at least make it a `/* C comment */` (our code-style agreement) or hide it under `#if 0`
slouken (Migrated from github.com) reviewed 2023-05-31 18:02:55 -05:00
libusb/hid.c
@ -678,0 +736,4 @@
0x10f5, /* Turtle Beach */
0x1532, /* Razer Wildcat */
0x20d6, /* PowerA */
0x24c6, /* PowerA */
slouken (Migrated from github.com) commented 2023-05-31 18:02:54 -05:00

Would this be the preferred naming convention for these constants?

xb360_iface_subclass, ..., supported_vendors
Would this be the preferred naming convention for these constants? ``` xb360_iface_subclass, ..., supported_vendors ```
Youw (Migrated from github.com) reviewed 2023-05-31 18:04:34 -05:00
libusb/hid.c
@ -678,0 +736,4 @@
0x10f5, /* Turtle Beach */
0x1532, /* Razer Wildcat */
0x20d6, /* PowerA */
0x24c6, /* PowerA */
Youw (Migrated from github.com) commented 2023-05-31 18:04:33 -05:00

yes

yes
slouken commented 2023-06-01 09:48:25 -05:00 (Migrated from github.com)

This has been updated with the suggestions.

This has been updated with the suggestions.
Youw (Migrated from github.com) approved these changes 2023-06-01 09:50:15 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
Youw
Labels
Clear labels   
3rdparty
3rd-party related issue/question

  
Android
Android OS related

  
API
API change, Version 1 stuff

  
Author does not respond

   
bsd
FreeBSD, NetBSD, OpenBSD, etc

  
bug
Something isn't working

  
build system/CI
Anything related to building the project or running on CI

  
ci-virtual-device
Run the virtual HID device CI jobs (Windows driver + libusb raw-gadget)

  
CMake
Related to CMake build system

  
Contributions Welcome
Any external help is welcome

  
Core
Related to common codes like hidapi.h

  
dependencies
Pull requests that update a dependency file

  
device-specific
Issues/PRs related to a specific device

  
documentation
Improvements or additions to documentation

  
don't_merge
Don't merge this PR as is

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
Example
Related to hidtest or new examples

  
Haiku
Related to Haiku OS (using libusb backend)

  
hidraw
Related to Linux/hidraw backend

  
hotplug
Related to hotplug

  
info required
Need more input from PR/issue author

  
invalid
Not a HIDAPI issue

  
libusb
Related to libusb backend

  
macOS
Related to macOS backend

  
Misc
Typo, whitespace, etc.

  
Not an issue

   
question
Information is requested

  
Release
Related to new release

  
Test
Related to built-in test (not hidtest)

  
Test GUI
Related to a Test GUI application

  
Windows
Related to Windows backend

  
wontfix
This will not be worked on

No labels
3rdparty
Android
API
Author does not respond
bsd
bug
build system/CI
ci-virtual-device
CMake
Contributions Welcome
Core
dependencies
device-specific
documentation
don't_merge
duplicate
enhancement
Example
Haiku
hidraw
hotplug
info required
invalid
libusb
macOS
Misc
Not an issue
question
Release
Test
Test GUI
Windows
wontfix
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-libusb/hidapi!572
No description provided.