gh-obsproject/obs-browser
Watch
1
0
Fork
You've already forked obs-browser
 0
Code Issues 37 Pull requests 13 Releases 15 Wiki Activity

Add option to use static runtime #125

Closed
computerquip-streamlabs wants to merge 1 commit from optional-crt into master
pull from: optional-crt
merge into: gh-obsproject:master
Conversation 1 Commits 1 Files changed 1 +6 -18
computerquip-streamlabs commented 2018-08-10 17:39:25 -05:00 (Migrated from github.com)

There appears to have been misconception of not being able to use /MD when using libcef. This isn't true due to the use of the libcef_dll_wrapper described here.

This adds an option to dynamically link against the runtime by setting BROWSER_USE_STATIC_CRT to a falsey value.

While I've set the default value here to true, I don't suggest statically against the runtime here at all. I've set it to default only because this is how it was already set and it felt less intrusive.

There appears to have been misconception of not being able to use /MD when using libcef. This isn't true due to the use of the libcef_dll_wrapper described [here](https://bitbucket.org/chromiumembedded/cef/wiki/LinkingDifferentRunTimeLibraries). This adds an option to dynamically link against the runtime by setting BROWSER_USE_STATIC_CRT to a falsey value. While I've set the default value here to true, I don't suggest statically against the runtime here at all. I've set it to default only because this is how it was already set and it felt less intrusive.
PatTheMav commented 2025-11-07 08:35:20 -06:00 (Migrated from github.com)

@WizardCM I think this can be closed - the underlying CMake implementation has obviously changed a lot in the last 7(!) years, but we also use the static CEF wrapper by default anyway (which is also independent of how CEF itself is linked/loaded anyway, as correctly pointed out).

@WizardCM I think this can be closed - the underlying CMake implementation has obviously changed a lot in the last 7(!) years, but we also use the static CEF wrapper by default anyway (which is also independent of how CEF itself is linked/loaded anyway, as correctly pointed out).

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
area/accessibility
Improves accessibility of the program

  
area/dependency
Issue is in external library or dependency, not OBS itself

  
Confirmed

   
Crash Report

   
Delayed
Merging has been delayed due to an issue

  
Design Issue
There is an issue with incorporating this pull request's design. It may take some time to finalize.

  
Duplicate

   
Feedback required
Issue does not contain enough information or is missing the template

  
Good first issue
New to contributing to OBS? Start here!

  
kind/bug
Categorizes issue or PR as related to a bug.

  
kind/cleanup
Non-breaking change which makes code smaller or more readable

  
kind/enhancement
Enhancements are not bugs or new features but can improve usability or performance.

  
platform/linux

   
platform/macos

   
platform/windows

   
priority/high
This is an important PR

  
Question

   
Request for Comments
More feedback & discussion is requested

  
Seeking Other Contributors
This PR needs help from any other developers who are willing to give a crack at this code

  
Seeking Testers

   
Won't Fix / By Design
No labels
area/accessibility
area/dependency
Confirmed
Crash Report
Delayed
Design Issue
Duplicate
Feedback required
Good first issue
kind/bug
kind/cleanup
kind/enhancement
platform/linux
platform/macos
platform/windows
priority/high
Question
Request for Comments
Seeking Other Contributors
Seeking Testers
Won't Fix / By Design
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-obsproject/obs-browser!125
No description provided.