gh-obsproject/obs-browser
Watch
1
0
Fork
You've already forked obs-browser
 0
Code Issues 37 Pull requests 13 Releases 15 Wiki Activity

obs-browser: flush panel cookie store on exit #155

Open
zavitax wants to merge 1 commit from StreamElements/flush_cookies_on_exit into master
pull from: StreamElements/flush_cookies_on_exit
merge into: gh-obsproject:master
Conversation 2 Commits 1 Files changed 2 +72
zavitax commented 2019-03-06 08:12:56 -06:00 (Migrated from github.com)

If cookie store is not flushed, state might become inconsistent:
reading from the cookies file will become impossible.
No errors will be returned, yet no information will be available,
and no information will be stored: the cookie manager will appear to be
empty at all times and the Cookies file modified date will not update
moving forward.

This will result, for example, in Twitch chat window re-opening for
users which connected their Twitch account, but not having the
auth-token cookie available: once the user will try to send a
message to the chat, they will be redirected to Twitch login screen.

If cookie store is not flushed, state might become inconsistent: reading from the cookies file will become impossible. No errors will be returned, yet no information will be available, and no information will be stored: the cookie manager will appear to be empty at all times and the `Cookies` file modified date will not update moving forward. This will result, for example, in Twitch chat window re-opening for users which connected their Twitch account, but not having the `auth-token` cookie available: once the user will try to send a message to the chat, they will be redirected to Twitch login screen.
PatTheMav commented 2025-11-07 08:45:04 -06:00 (Migrated from github.com)

@zavitax Is this still an issue with the current version of OBS Studio?

@zavitax Is this still an issue with the current version of OBS Studio?
zavitax commented 2025-11-12 05:00:32 -06:00 (Migrated from github.com)

@zavitax Is this still an issue with the current version of OBS Studio?

We still see occasional reports which resemble this case, yes.

> @zavitax Is this still an issue with the current version of OBS Studio? We still see occasional reports which resemble this case, yes.
This pull request has changes conflicting with the target branch.
  • obs-browser-plugin.cpp
  • panel/browser-panel.cpp
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin 'StreamElements/flush_cookies_on_exit:StreamElements/flush_cookies_on_exit'
git switch 'StreamElements/flush_cookies_on_exit'

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch 'master'
git merge --no-ff 'StreamElements/flush_cookies_on_exit'
git switch 'StreamElements/flush_cookies_on_exit'
git rebase 'master'
git switch 'master'
git merge --ff-only 'StreamElements/flush_cookies_on_exit'
git switch 'StreamElements/flush_cookies_on_exit'
git rebase 'master'
git switch 'master'
git merge --no-ff 'StreamElements/flush_cookies_on_exit'
git switch 'master'
git merge --squash 'StreamElements/flush_cookies_on_exit'
git switch 'master'
git merge --ff-only 'StreamElements/flush_cookies_on_exit'
git switch 'master'
git merge 'StreamElements/flush_cookies_on_exit'
git push origin 'master'
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
area/accessibility
Improves accessibility of the program

  
area/dependency
Issue is in external library or dependency, not OBS itself

  
Confirmed

   
Crash Report

   
Delayed
Merging has been delayed due to an issue

  
Design Issue
There is an issue with incorporating this pull request's design. It may take some time to finalize.

  
Duplicate

   
Feedback required
Issue does not contain enough information or is missing the template

  
Good first issue
New to contributing to OBS? Start here!

  
kind/bug
Categorizes issue or PR as related to a bug.

  
kind/cleanup
Non-breaking change which makes code smaller or more readable

  
kind/enhancement
Enhancements are not bugs or new features but can improve usability or performance.

  
platform/linux

   
platform/macos

   
platform/windows

   
priority/high
This is an important PR

  
Question

   
Request for Comments
More feedback & discussion is requested

  
Seeking Other Contributors
This PR needs help from any other developers who are willing to give a crack at this code

  
Seeking Testers

   
Won't Fix / By Design
No labels
area/accessibility
area/dependency
Confirmed
Crash Report
Delayed
Design Issue
Duplicate
Feedback required
Good first issue
kind/bug
kind/cleanup
kind/enhancement
platform/linux
platform/macos
platform/windows
priority/high
Question
Request for Comments
Seeking Other Contributors
Seeking Testers
Won't Fix / By Design
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-obsproject/obs-browser!155
No description provided.