Linux support #166

Merged
bazukas merged 1 commit from master into master 2020-02-26 06:33:14 -06:00
bazukas commented 2019-06-24 17:50:48 -05:00 (Migrated from github.com)

Inspired by #159
Closes https://github.com/obsproject/obs-browser/issues/141
Add FindCEF and install instructions for Linux.

Works on Linux when built with CEF version 3683 and obs-studio launched with QT_NO_GLIB=1.

Inspired by #159 Closes https://github.com/obsproject/obs-browser/issues/141 Add FindCEF and install instructions for Linux. Works on Linux when built with CEF version 3683 and obs-studio launched with QT_NO_GLIB=1.
WizardCM commented 2019-06-24 17:54:16 -05:00 (Migrated from github.com)

We're hoping to switch to CEF 3770 for #157, could you test that too?

We're hoping to switch to CEF 3770 for #157, could you test that too?
bazukas commented 2019-06-24 18:26:07 -05:00 (Migrated from github.com)

I replayed my commit on top of pkviet:audio-dev and built with 3770,
can confirm that it seems to work.

I replayed my commit on top of pkviet:audio-dev and built with 3770, can confirm that it seems to work.
bazukas commented 2019-06-24 18:35:58 -05:00 (Migrated from github.com)

Currently there is a minor issue with this piece of code in panel/browser-panel.hpp:

static inline QCef *obs_browser_init_panel(void)
{
#ifdef _WIN32
	void *lib = os_dlopen("obs-browser");
#else
	void *lib = os_dlopen("../obs-plugins/obs-browser");
#endif

It does not matter currently because it is only used on windows anyway.
I don't know what's the best way to find the plugin file on linux, help would be appreciated.

Currently there is a minor issue with this piece of code in panel/browser-panel.hpp: ``` static inline QCef *obs_browser_init_panel(void) { #ifdef _WIN32 void *lib = os_dlopen("obs-browser"); #else void *lib = os_dlopen("../obs-plugins/obs-browser"); #endif ``` It does not matter currently because it is only used on windows anyway. I don't know what's the best way to find the plugin file on linux, help would be appreciated.
WizardCM commented 2019-06-24 18:37:39 -05:00 (Migrated from github.com)

Panels have, unfortunately, only been extensively tested on Windows, however we do want to roll out the panels on macOS and Linux as soon as we can. 23.2 had a number of macOS-specific fixes to pave the way.

Panels have, unfortunately, only been extensively tested on Windows, however we do want to roll out the panels on macOS and Linux as soon as we can. 23.2 had a number of macOS-specific fixes to pave the way.
WizardCM commented 2019-07-13 05:05:20 -05:00 (Migrated from github.com)

There were updates today for CEF 3770 compatibility. Feel free to update when you have time.

There were updates today for CEF 3770 compatibility. Feel free to update when you have time.
bazukas commented 2019-07-14 14:05:33 -05:00 (Migrated from github.com)

Thanks for the heads up, updated this PR.

Thanks for the heads up, updated this PR.
lambdadog commented 2019-08-08 17:11:34 -05:00 (Migrated from github.com)

anything keeping this back from being merged @WizardCM ? Very interested in seeing this move forward as while there is an existing alternative plugin for linux, official support would be very nice for this widely used plugin

anything keeping this back from being merged @WizardCM ? Very interested in seeing this move forward as while there is an existing alternative plugin for linux, official support would be very nice for this widely used plugin
WizardCM commented 2019-08-08 17:15:22 -05:00 (Migrated from github.com)

Basically waiting on review from Jim. We're definitely keeping an eye on things.

Basically waiting on review from Jim. We're definitely keeping an eye on things.
Palakis commented 2019-09-06 08:25:04 -05:00 (Migrated from github.com)

Regarding browser panels on Linux: so far the browser view doesn't show up in the dock widget but in another window outside of it.

image

Regarding browser panels on Linux: so far the browser view doesn't show up in the dock widget but in another window outside of it. ![image](https://user-images.githubusercontent.com/1812130/64431185-36006200-d0ba-11e9-9d8a-c2f85e738aba.png)
jp9000 commented 2019-10-04 15:11:53 -05:00 (Migrated from github.com)

When we're finished with 24 minor updates I'm going to check it out and hopefully merge this just for the record.

When we're finished with 24 minor updates I'm going to check it out and hopefully merge this just for the record.
WizardCM commented 2019-10-04 18:17:16 -05:00 (Migrated from github.com)

For anyone interested in testing the browser source, please check https://github.com/obsproject/obs-studio/pull/1759#issuecomment-538588568 for the full list of cases.

For anyone interested in testing the browser source, please check https://github.com/obsproject/obs-studio/pull/1759#issuecomment-538588568 for the full list of cases.
martinpl commented 2020-02-05 16:48:47 -06:00 (Migrated from github.com)

Anyone have hack for not popping out browser window from dock widget?

Anyone have hack for not popping out browser window from dock widget?
cg2121 commented 2020-02-19 20:03:04 -06:00 (Migrated from github.com)

@bazukas do you compile CEF yourself, and if so, do you have a script for compiling it?

@bazukas do you compile CEF yourself, and if so, do you have a script for compiling it?
bazukas commented 2020-02-20 01:08:38 -06:00 (Migrated from github.com)
@cg2121 I download from http://opensource.spotify.com/cefbuilds/index.html
Sign in to join this conversation.
No reviewers
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-obsproject/obs-browser!166
No description provided.