Remove unused code #179

Merged

RytoEX merged 1 commit from clean-code into master

2020-02-08 03:03:53 -06:00

RytoEX commented

2019-10-10 01:33:04 -05:00

(Migrated from github.com)

Description

This change removes some unused code that was introduced in the 2.0 rewrite. As far as I can tell, the code is never used or referenced. I could not tell if this gets passed to CEF via QueueCEFTask, so hopefully someone (probably Jim) can confirm that this code is really unused.

Motivation and Context

Keeping the code clean.

How Has This Been Tested?

I compiled and tested this on Windows 10 Home 1903 (Build 18362.388) 64-bit with VS2017. I ran OBS and created a new browser source, saved it, closed OBS, and reopened OBS.

Types of changes

Code cleanup (non-breaking change which makes code smaller or more readable)

Checklist:

My code has been run through clang-format.
I have read the contributing document.
My code is not on the master branch.
The code has been tested.
All commit messages are properly formatted and commits squashed where appropriate.

### Description This change removes some unused code that was [introduced in the 2.0 rewrite](https://github.com/obsproject/obs-browser/blob/46116403705b482eeccd0c2d1d2136c8a610747f/obs-browser-source.cpp#L88). As far as I can tell, the code is never used or referenced. I could not tell if this gets passed to CEF via `QueueCEFTask`, so hopefully someone (probably Jim) can confirm that this code is really unused. ### Motivation and Context Keeping the code clean. ### How Has This Been Tested? I compiled and tested this on Windows 10 Home 1903 (Build 18362.388) 64-bit with VS2017. I ran OBS and created a new browser source, saved it, closed OBS, and reopened OBS. ### Types of changes - Code cleanup (non-breaking change which makes code smaller or more readable) ### Checklist: - [x] My code has been run through [clang-format](https://github.com/obsproject/obs-studio/blob/master/.clang-format). - [x] I have read the [**contributing** document](https://github.com/obsproject/obs-studio/blob/master/CONTRIBUTING.rst). - [x] My code is not on the master branch. - [x] The code has been tested. - [x] All commit messages are properly formatted and commits squashed where appropriate.

WizardCM commented

2019-12-27 22:34:03 -06:00

(Migrated from github.com)

I can confirm this doesn't seem to be used.

No reviewers

No milestone

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

gh-obsproject/obs-browser!179

No description provided.

Rows
Columns