Remove fractional scaling ifdefs #273

Merged

RytoEX merged 1 commit from remove-fractional-ifdefs into master

2021-06-30 03:41:33 -05:00

RytoEX commented

2021-03-25 20:01:31 -05:00

(Migrated from github.com)

Description

Remove ifdefs for fractional scaling support (Qt 5.6+).

Motivation and Context

Among the systems we officially support, the oldest Qt version is Qt 5.9 on Ubuntu 18.04. Fractional scaling is supported in Qt 5.6 and newer. We should be able to safely remove these ifdefs and simplify the code.

@WizardCM Wanted me to check what Qt versions FreeBSD and Arch currently offer, and they both offer Qt 5.15.2. Xenial (Ubuntu 16.04) still has Qt 5.5, but we no longer officially support that platform, and its End of Standard Support is April 2021, so I don't think we need to worry about it.

How Has This Been Tested?

Compiled and ran OBS and obs-browser on Windows 10 64-bit with these changes. I verified that browser docks behave the same in OBS Studio 26.1.1 and after this patch.

Types of changes

Code cleanup (non-breaking change which makes code smaller or more readable)

Checklist:

My code has been run through clang-format.
I have read the contributing document.
My code is not on the master branch.
The code has been tested.
All commit messages are properly formatted and commits squashed where appropriate.
I have included updates to all appropriate documentation.

### Description   Remove ifdefs for fractional scaling support (Qt 5.6+). ### Motivation and Context    Among the systems we officially support, the oldest Qt version is Qt 5.9 on Ubuntu 18.04. Fractional scaling is supported in Qt 5.6 and newer. We should be able to safely remove these ifdefs and simplify the code. @WizardCM Wanted me to check what Qt versions FreeBSD and Arch currently offer, and they both offer Qt 5.15.2. Xenial (Ubuntu 16.04) still has Qt 5.5, but we no longer officially support that platform, and its End of Standard Support is April 2021, so I don't think we need to worry about it. ### How Has This Been Tested?    Compiled and ran OBS and obs-browser on Windows 10 64-bit with these changes. I verified that browser docks behave the same in OBS Studio 26.1.1 and after this patch. ### Types of changes     - Code cleanup (non-breaking change which makes code smaller or more readable)   ### Checklist:   - [x] My code has been run through [clang-format](https://github.com/obsproject/obs-studio/blob/master/.clang-format). - [x] I have read the [**contributing** document](https://github.com/obsproject/obs-studio/blob/master/CONTRIBUTING.rst). - [x] My code is not on the master branch. - [x] The code has been tested. - [x] All commit messages are properly formatted and commits squashed where appropriate. - [x] I have included updates to all appropriate documentation.

WizardCM (Migrated from github.com) reviewed

2021-03-25 20:01:31 -05:00

No reviewers

WizardCM

No milestone

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

gh-obsproject/obs-browser!273

No description provided.

Rows
Columns