Remove old CEF support #497

Merged
RytoEX merged 8 commits from remove-old-cef-support into master 2025-08-23 11:04:02 -05:00
RytoEX commented 2025-08-23 00:09:34 -05:00 (Migrated from github.com)

Description

Remove support for CEF versions older than 95/5060. This includes removing:

  • custom audio handling (pre-4103)
  • ENABLE_WASHIDDEN
  • ENABLE_LOCAL_FILE_URL_SCHEME

Motivation and Context

We currently only support building against CEF 95/5060 and up. We actually only target much more recent versions, but we had previously settled on pruning pre-5060 code at some point in the future, and I wanted to keep to that scope.

Some lower bounds checks were left in place for now to (hopefully) maintain clarity with those checks.

How Has This Been Tested?

Compiled and ran on Windows 11.

cc @pkviet

Types of changes

  • Code cleanup (non-breaking change which makes code smaller or more readable)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.
<!--- Please fill out the following template, which will help other contributors review your Pull Request. --> <!--- Make sure you’ve read the contribution guidelines here: https://github.com/obsproject/obs-studio/blob/master/CONTRIBUTING.rst --> ### Description <!--- Describe your changes in detail. --> <!--- If this change includes UI elements, please include screenshots. --> Remove support for CEF versions older than 95/5060. This includes removing: * custom audio handling (pre-4103) * ENABLE_WASHIDDEN * ENABLE_LOCAL_FILE_URL_SCHEME ### Motivation and Context <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open GitHub Issue, or implements feature request --> <!--- from the Ideas page, please link to the issue here. --> We currently only support building against CEF 95/5060 and up. We actually only target much more recent versions, but we had previously settled on pruning pre-5060 code at some point in the future, and I wanted to keep to that scope. Some lower bounds checks were left in place for now to (hopefully) maintain clarity with those checks. ### How Has This Been Tested? <!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment (hardware, OS version, etc.),--> <!--- and the tests you ran, including how it may affect other areas of code. --> Compiled and ran on Windows 11. cc @pkviet ### Types of changes <!--- What types of changes does your PR introduce? Uncomment all that apply --> <!--- - Bug fix (non-breaking change which fixes an issue) --> <!--- - New feature (non-breaking change which adds functionality) --> <!--- - Tweak (non-breaking change to improve existing functionality) --> <!--- - Performance enhancement (non-breaking change which improves efficiency) --> - Code cleanup (non-breaking change which makes code smaller or more readable) <!--- - Breaking change (fix or feature that would cause existing functionality to change) --> <!--- - Documentation (a change to documentation pages) --> ### Checklist: <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] My code has been run through [clang-format](https://github.com/obsproject/obs-studio/blob/master/.clang-format). - [x] I have read the [**contributing** document](https://github.com/obsproject/obs-studio/blob/master/CONTRIBUTING.rst). - [x] My code is not on the master branch. - [x] The code has been tested. - [x] All commit messages are properly formatted and commits squashed where appropriate. - [x] I have included updates to all appropriate documentation.
PatTheMav (Migrated from github.com) reviewed 2025-08-23 00:09:34 -05:00
WizardCM (Migrated from github.com) approved these changes 2025-08-23 02:30:52 -05:00
WizardCM (Migrated from github.com) left a comment

Diff looks correct, removes any code older than 5060.

Diff looks correct, removes any code older than 5060.
pkviet (Migrated from github.com) approved these changes 2025-08-23 02:52:49 -05:00
pkviet (Migrated from github.com) left a comment

LGTM

LGTM
Sign in to join this conversation.
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-obsproject/obs-browser!497
No description provided.