Add pybstick26_rp2040 support #636

2021-10-27T04:26:04-05:00

garatronic commented

2021-10-27 04:26:04 -05:00

(Migrated from github.com)

No description provided.

lurch (Migrated from github.com) reviewed

2021-10-27 05:49:56 -05:00

src/boards/include/boards/pybstick26_rp2040.h

					
				@ -0,0 +1,85 @@

				/*

This line needs updating 😉 (should be "boards/pybstick26_rp2040.h")

This line needs updating :wink: (should be "boards/pybstick26_rp2040.h")

lurch (Migrated from github.com) reviewed

2021-10-27 05:54:18 -05:00

src/boards/include/boards/pybstick26_rp2040.h

					
				@ -0,0 +1,85 @@

				/*

Could you make a similar change to this please? https://github.com/raspberrypi/pico-sdk/pull/619/commits/c682e3c6974f1bdbbf45c513ad80343498e2b222
(Assuming of course that none of your boards are produced with RP2040 B0)

Could you make a similar change to this please? https://github.com/raspberrypi/pico-sdk/pull/619/commits/c682e3c6974f1bdbbf45c513ad80343498e2b222 (Assuming of course that none of your boards are produced with RP2040 B0)

garatronic (Migrated from github.com) reviewed

2021-10-27 07:21:43 -05:00

src/boards/include/boards/pybstick26_rp2040.h

					
				@ -0,0 +1,85 @@

				/*

ooops. you're right.

garatronic (Migrated from github.com) reviewed

2021-10-27 07:22:16 -05:00

src/boards/include/boards/pybstick26_rp2040.h

					
				@ -0,0 +1,85 @@

				/*

ok, thanks for the update.

garatronic commented

2021-10-27 07:38:16 -05:00

(Migrated from github.com)

Did not git since a while, sorry ;)
Corrections should be ok now.

Did not git since a while, sorry ;) Corrections should be ok now.

lurch (Migrated from github.com) reviewed

2021-10-27 08:00:06 -05:00

src/boards/include/boards/pybstick26_rp2040.h

					
				@ -0,0 +1,85 @@

				/*

Sorry, looking at the other files in the src/boards/include/boards/ directory, I now realise that it's probably better to get rid of this line entirely.

Sorry, looking at the other files in the `src/boards/include/boards/` directory, I now realise that it's probably better to get rid of this line entirely.

lurch (Migrated from github.com) reviewed

2021-10-27 08:04:03 -05:00

src/boards/include/boards/pybstick26_rp2040.h

					
				@ -0,0 +79,4 @@

				// All boards have B1 RP2040

				#ifndef PICO_RP2040_B0_SUPPORTED 

				#define PICO_RP2040_B0_SUPPORTED  0

				#endif

This #endif matches up with #ifndef PICO_RP2040_B0_SUPPORTED, but you seem to have lost the final #endif that matches up with the #ifndef _BOARDS_PYBSTICK26_RP2040_H ?
TLDR: you need another #endif line at the bottom 😉

This `#endif` matches up with `#ifndef PICO_RP2040_B0_SUPPORTED`, but you seem to have lost the final `#endif` that matches up with the `#ifndef _BOARDS_PYBSTICK26_RP2040_H` ? TLDR: you need another `#endif` line at the bottom :wink:

garatronic (Migrated from github.com) reviewed

2021-10-27 08:17:36 -05:00

src/boards/include/boards/pybstick26_rp2040.h

					
				@ -0,0 +79,4 @@

				// All boards have B1 RP2040

				#ifndef PICO_RP2040_B0_SUPPORTED 

				#define PICO_RP2040_B0_SUPPORTED  0

				#endif

Also right. I double check and compile a firmware. Seens to be ok now.
Thanks.

Also right. I double check and compile a firmware. Seens to be ok now. Thanks.

lurch (Migrated from github.com) reviewed

2021-10-27 08:20:44 -05:00

lurch (Migrated from github.com) left a comment

No description provided.

LGTM

kilograham (Migrated from github.com) reviewed

2021-10-27 12:27:53 -05:00

src/boards/include/boards/pybstick26_rp2040.h

					
				@ -0,0 +1,85 @@

				/*

yup. i'm assuming no one has a reason to include this board in another one

kilograham (Migrated from github.com) reviewed

2021-10-30 17:33:11 -05:00

src/boards/include/boards/pybstick26_rp2040.h

					
				@ -0,0 +1,85 @@

				/*

@garatronic can you remove this line real quick

garatronic commented

2021-10-31 04:39:16 -05:00

(Migrated from github.com)

@kilograham

This is (hopefully) done in third commit bd6b8c7bdd of my pull request

De: "Graham Sanderson" @.>
À: "raspberrypi/pico-sdk" @.>
Cc: "Frédéric Pierson" @.>, "Mention" @.>
Envoyé: Dimanche 31 Octobre 2021 00:33:21
Objet: Re: [raspberrypi/pico-sdk] Add pybstick26_rp2040 support (PR #636)

@kilograham commented on this pull request.

In [ https://github.com/raspberrypi/pico-sdk/pull/636#discussion_r739723130 | src/boards/include/boards/pybstick26_rp2040.h ] :

@@ -0,0 +1,84 @@
+/*

- Copyright (c) 2020 Raspberry Pi (Trading) Ltd.
- SPDX-License-Identifier: BSD-3-Clause
*/

+// -----------------------------------------------------
+// NOTE: THIS HEADER IS ALSO INCLUDED BY ASSEMBLER SO
+// SHOULD ONLY CONSIST OF PREPROCESSOR DIRECTIVES
+// -----------------------------------------------------
+
+// This header may be included by other board headers as "boards/pybstick26_rp2040.h"

[ https://github.com/garatronic | @garatronic ] can you remove this line real quick

—
You are receiving this because you were mentioned.
Reply to this email directly, [ https://github.com/raspberrypi/pico-sdk/pull/636#discussion_r739723130 | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/AHNK7YSZ7XORYH45UBDUSXLUJRXDDANCNFSM5GZ3CQ5A | unsubscribe ] .
Triage notifications on the go with GitHub Mobile for [ https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 | iOS ] or [ https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub | Android ] .

@kilograham This is (hopefully) done in third commit bd6b8c7bdd3bc0a3c48dcef1e02eb72aaaeddca9 of my pull request De: "Graham Sanderson" ***@***.***> À: "raspberrypi/pico-sdk" ***@***.***> Cc: "Frédéric Pierson" ***@***.***>, "Mention" ***@***.***> Envoyé: Dimanche 31 Octobre 2021 00:33:21 Objet: Re: [raspberrypi/pico-sdk] Add pybstick26_rp2040 support (PR #636) @kilograham commented on this pull request. In [ https://github.com/raspberrypi/pico-sdk/pull/636#discussion_r739723130 | src/boards/include/boards/pybstick26_rp2040.h ] : > @@ -0,0 +1,84 @@ +/* + * Copyright (c) 2020 Raspberry Pi (Trading) Ltd. + * + * SPDX-License-Identifier: BSD-3-Clause + */ + +// ----------------------------------------------------- +// NOTE: THIS HEADER IS ALSO INCLUDED BY ASSEMBLER SO +// SHOULD ONLY CONSIST OF PREPROCESSOR DIRECTIVES +// ----------------------------------------------------- + +// This header may be included by other board headers as "boards/pybstick26_rp2040.h" [ https://github.com/garatronic | @garatronic ] can you remove this line real quick — You are receiving this because you were mentioned. Reply to this email directly, [ https://github.com/raspberrypi/pico-sdk/pull/636#discussion_r739723130 | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/AHNK7YSZ7XORYH45UBDUSXLUJRXDDANCNFSM5GZ3CQ5A | unsubscribe ] . Triage notifications on the go with GitHub Mobile for [ https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 | iOS ] or [ https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub | Android ] .

kilograham (Migrated from github.com) reviewed

2021-10-31 09:30:59 -05:00

kilograham (Migrated from github.com) approved these changes

2021-10-31 09:31:42 -05:00

Sign in to join this conversation.

No reviewers

kilograham