IRQ on CYW43_PIN_WL_HOST_WAKE not gpio13 #1069

Merged

envirocoder merged 4 commits from patch-2 into develop

2022-11-24 08:42:26 -06:00

envirocoder commented

2022-10-17 11:56:38 -05:00

(Migrated from github.com)

fixes #1068 where the raw irq handler that was added masked on IO_IRQ_BANK0 (defined as 13) and not the gpio connected to the CYW43 i.e. CYW43_PIN_WL_HOST_WAKE

peterharperuk commented

2022-10-17 12:11:47 -05:00

(Migrated from github.com)

Looks good!

lurch commented

2022-10-17 17:55:33 -05:00

(Migrated from github.com)

Is a similar change also needed on line 212 ?

envirocoder commented

2022-10-18 02:52:06 -05:00

(Migrated from github.com)

Is a similar change also needed on line 212 ?

good spot.

> Is a similar change also needed on line 212 ? good spot.

lurch commented

2022-10-18 03:04:05 -05:00

(Migrated from github.com)

peterharperuk commented

2022-10-18 04:15:30 -05:00

(Migrated from github.com)

Also similar problems in https://github.com/raspberrypi/pico-sdk/blob/develop/src/rp2_common/pico_cyw43_arch/cyw43_arch_poll.c#L62 and https://github.com/raspberrypi/pico-sdk/blob/develop/src/rp2_common/pico_cyw43_arch/cyw43_arch_freertos.c#L141 ?

Yes - looks like the same mistake.

> Also similar problems in https://github.com/raspberrypi/pico-sdk/blob/develop/src/rp2_common/pico_cyw43_arch/cyw43_arch_poll.c#L62 and https://github.com/raspberrypi/pico-sdk/blob/develop/src/rp2_common/pico_cyw43_arch/cyw43_arch_freertos.c#L141 ? Yes - looks like the same mistake.

envirocoder commented

2022-10-18 10:40:22 -05:00

(Migrated from github.com)

Also similar problems in https://github.com/raspberrypi/pico-sdk/blob/develop/src/rp2_common/pico_cyw43_arch/cyw43_arch_poll.c#L62 and https://github.com/raspberrypi/pico-sdk/blob/develop/src/rp2_common/pico_cyw43_arch/cyw43_arch_freertos.c#L141 ?

Yes - looks like the same mistake.

Yep -- I'll try and fix/test the others too later this week unless someone else gets in before me!

> > Also similar problems in https://github.com/raspberrypi/pico-sdk/blob/develop/src/rp2_common/pico_cyw43_arch/cyw43_arch_poll.c#L62 and https://github.com/raspberrypi/pico-sdk/blob/develop/src/rp2_common/pico_cyw43_arch/cyw43_arch_freertos.c#L141 ? > > Yes - looks like the same mistake. Yep -- I'll try and fix/test the others too later this week unless someone else gets in before me!

envirocoder commented

2022-10-28 08:38:25 -05:00

(Migrated from github.com)