sdio_uart: avoid generating garbage input due to initialization #1125

Merged
DipSwitch merged 1 commit from patch-1 into develop 2023-01-19 16:39:19 -06:00
DipSwitch commented 2022-12-01 05:44:13 -06:00 (Migrated from github.com)

First mapping the GPIO pins to the UART peripheral before enabling the UART peripheral avoids generation of garbage character on the UART's input.

Fixes: #1124

First mapping the GPIO pins to the UART peripheral before enabling the UART peripheral avoids generation of garbage character on the UART's input. Fixes: #1124
kilograham (Migrated from github.com) approved these changes 2023-01-19 16:39:08 -06:00
kilograham commented 2023-01-19 16:39:26 -06:00 (Migrated from github.com)

thanks

thanks
notro commented 2023-02-03 09:59:28 -06:00 (Migrated from github.com)

Maybe update the example in uart.h.

Maybe update the example in [uart.h](https://github.com/raspberrypi/pico-sdk/blob/develop/src/rp2_common/hardware_uart/include/hardware/uart.h#L57-L67).
shuffle2 commented 2023-09-30 17:00:37 -05:00 (Migrated from github.com)

please update the docs/examples i just ran into this problem and was lucky to find this PR!

**please update the docs/examples** i just ran into this problem and was lucky to find this PR!
lurch commented 2023-10-01 18:44:01 -05:00 (Migrated from github.com)

@shuffle2 Could you let us know which parts of the docs/examples need updating please?

EDIT: If you want to make a new issue in the https://github.com/raspberrypi/pico-feedback repo that would be perfect.

@shuffle2 Could you let us know which parts of the **docs/examples** need updating please? EDIT: If you want to make a new issue in the https://github.com/raspberrypi/pico-feedback repo that would be perfect.
shuffle2 commented 2024-04-12 12:00:30 -05:00 (Migrated from github.com)

@lurch I was referring to the example which notro linked to: https://github.com/raspberrypi/pico-sdk/blob/develop/src/rp2_common/hardware_uart/include/hardware/uart.h#L57-L67 which is in this repo, so should be tracked/fixed here?

@lurch I was referring to the example which notro linked to: https://github.com/raspberrypi/pico-sdk/blob/develop/src/rp2_common/hardware_uart/include/hardware/uart.h#L57-L67 which is in this repo, so should be tracked/fixed here?
peterharperuk commented 2024-04-12 12:16:27 -05:00 (Migrated from github.com)

Understood, I raised an issue so it won't be forgotten about https://github.com/raspberrypi/pico-sdk/issues/1685

Understood, I raised an issue so it won't be forgotten about https://github.com/raspberrypi/pico-sdk/issues/1685
Sign in to join this conversation.
No reviewers
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-raspberrypi/pico-sdk!1125
No description provided.