add 0xcb helios #1174

2023-01-14T12:25:33-06:00

Conor-Burns commented

2023-01-14 12:25:33 -06:00

(Migrated from github.com)

Adding 0xCB Helios

Adding 0xCB Helios [source](https://github.com/0xCB-dev/0xCB-Helios) ![](https://github.com/0xCB-dev/0xCB-Helios/raw/main/rev1.0/helios.webp)

kilograham (Migrated from github.com) reviewed

2023-01-19 16:21:00 -06:00

src/boards/include/boards/0xcb_helios.h

					
				@ -0,0 +16,4 @@

				#define _BOARDS_0XCB_HELIOS_H

				// For board detection

				#define 0XCB_HELIOS

Um; that surely doesn't compile!

kilograham (Migrated from github.com) requested changes

2023-01-23 12:51:47 -06:00

kilograham (Migrated from github.com) left a comment

as per comment, this header won't compile

peterharperuk (Migrated from github.com) reviewed

2023-05-16 12:29:16 -05:00

src/boards/include/boards/0xcb_helios.h

					
				@ -0,0 +16,4 @@

				#define _BOARDS_0XCB_HELIOS_H

				// For board detection

				#define 0XCB_HELIOS

error: macro names must be identifiers

kilograham commented

2023-05-25 15:06:05 -05:00

(Migrated from github.com)

please fix this if you want it added

kilograham commented

2024-05-19 17:34:51 -05:00

(Migrated from github.com)

As OP doesn't seem to be around, I suggest we just add an _ to the define and commit this (i would have done so in passing, but i can't edit the commit in the original repo)

As OP doesn't seem to be around, I suggest we just add an `_` to the define and commit this (i would have done so in passing, but i can't edit the commit in the original repo)

lurch commented

2024-06-05 13:31:17 -05:00

(Migrated from github.com)

As OP doesn't seem to be around, I suggest we just add an _ to the define and commit this (i would have done so in passing, but i can't edit the commit in the original repo)

Done that in #1724

> As OP doesn't seem to be around, I suggest we just add an `_` to the define and commit this (i would have done so in passing, but i can't edit the commit in the original repo) Done that in #1724

kilograham commented

2024-06-21 14:27:22 -05:00

(Migrated from github.com)