Make linker fill alignment gaps with bkpt instruction #1305

Open

bruelltuete wants to merge 1 commit from bruelltuete/linkerfill into develop

bruelltuete commented

2023-03-10 19:10:02 -06:00

(Migrated from github.com)

Request for comment: what do you think of this?
This came out from https://forums.raspberrypi.com/viewtopic.php?p=2089017#p2088888.

The linker fills in some gaps that result from alignment. But it filled in just zeros. Would it be better if those filler bytes would trigger a breakpoint or fault in case they are ever executed?

(and thanks to alastairpatrick for suggesting bkpt instead of udf)

Request for comment: what do you think of this? This came out from https://forums.raspberrypi.com/viewtopic.php?p=2089017#p2088888. The linker fills in some gaps that result from alignment. But it filled in just zeros. Would it be better if those filler bytes would trigger a breakpoint or fault in case they are ever executed? (and thanks to alastairpatrick for suggesting bkpt instead of udf)

kilograham commented

2023-05-25 15:07:22 -05:00

(Migrated from github.com)

revisit when we do some cleanup of linker scripts

This pull request has changes conflicting with the target branch.

src/rp2_common/pico_standard_link/memmap_default.ld

View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Merge commit title

Merge pull request 'Make linker fill alignment gaps with bkpt instruction' (#1305) from bruelltuete/linkerfill into develop

Merge commit body

Reviewed-on: https://git.richey.dev/gh-raspberrypi/pico-sdk/pulls/1305

Merge pull request 'Make linker fill alignment gaps with bkpt instruction' (#1305) from bruelltuete/linkerfill into develop

Reviewed-on: https://git.richey.dev/gh-raspberrypi/pico-sdk/pulls/1305

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin 'bruelltuete/linkerfill:bruelltuete/linkerfill'

git switch 'bruelltuete/linkerfill'

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch 'develop'

git merge --no-ff 'bruelltuete/linkerfill'

git switch 'bruelltuete/linkerfill'

git rebase 'develop'

git switch 'develop'

git merge --ff-only 'bruelltuete/linkerfill'

git switch 'bruelltuete/linkerfill'

git rebase 'develop'

git switch 'develop'

git merge --no-ff 'bruelltuete/linkerfill'

git switch 'develop'

git merge --squash 'bruelltuete/linkerfill'