Add watchdog parameter-validation, and fix up misleading comments #1567
No reviewers
Labels
No labels
bazel
bluetooth
board settings
boot_stage2
bug
build
c++
can't reproduce
clang
clib-interface
cmsis
code cleanliness
code size
compiler version issues
cyw43_driver
debug
discussion
documentation
duplicate
dynamic_clock
elf2uf2
enhancement
errata
filesystem
flash layout
floating point
FreeRTOS
hardware_adc
hardware_claim
hardware_clocks
hardware_dma
hardware_exception
hardware_flash
hardware_gpio
hardware_i2c
hardware_irq
hardware_pio
hardware_pwm
hardware_rcp
hardware_rtc
hardware_spi
hardware_sync
hardware_uart
hardware_vreg
hardware_watchdog
hardware_xosc
help wanted
host
IAR
installation
invalid
linker scripts
lto
lwip
mbedtls
missing API
needs reporter detail
networking
newlib
newlib-multicore
non-c
non-cmake
non-gcc
openocd
orphan PR
OS integration
pico_async_context
pico_base
pico_binary_info
pico_flash
picolibc
pico_lwip
pico_malloc
pico_multicore
pico_printf
pico_runtime
pico_stdio
pico_stdio_usb
pico_sync
pico_time
pico_util
pioasm
port
question
review
review2
rtos interop
runtime init
static library
svd
test
tinyusb
vscode
wifi integration
wontfix
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
gh-raspberrypi/pico-sdk!1567
Loading…
Reference in a new issue
No description provided.
Delete branch "watchdog_delay_fixups"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Fixes #1238 and #1550 (and #1241 #1409 #1505 which are duplicates of #1238)
Only tiny nits.
@ -43,3 +48,3 @@* \param delay_ms Initial load value. Maximum value 0x7fffff, approximately 8.3s.* \param delay_ms Initial load value. Maximum value 8388, approximately 8.3s.*/void watchdog_reboot(uint32_t pc, uint32_t sp, uint32_t delay_ms);8.3 IIF the source clock is default?
8.3 IIF the source clock is default?
Magic number, although it is commented. Move to a define? Only a nit though.
@ -43,3 +48,3 @@* \param delay_ms Initial load value. Maximum value 0x7fffff, approximately 8.3s.* \param delay_ms Initial load value. Maximum value 8388, approximately 8.3s.*/void watchdog_reboot(uint32_t pc, uint32_t sp, uint32_t delay_ms);Well, you could argue that the
\note If \ref watchdog_start_tick value does not give a 1MHz clock to the watchdog system, then the \p delay_ms parameter will not be in milliseconds. See the datasheet for more details.already covers that ? 🤷♂️Could do, but I'm not sure if it's worth it when it only appears once in a debug-level assert?