Assert ordering of pins in bi_pins_with_names is correct #1791

Closed

will-v-pi wants to merge 1 commit from bi-pins-order-assert into develop

will-v-pi commented

2024-08-09 09:31:04 -05:00

(Migrated from github.com)

Fixes #878 by adding an assertion that the ordering of pins in bi_pins_with_names is correct

The pins are passed as a pin mask, so there is no ordering, and therefore the pins must be given in ascending order else the names will be associated with the wrong pins

This breaks compilation of the pio/spi/spi_flash example, as the pins there are not in order - given the default pins could be in any order depending on the board, that example should probably be modified to have 4 separate bi_1pin_with_name lines instead of a single bi_4pins_with_names

Fixes #878 by adding an assertion that the ordering of pins in bi_pins_with_names is correct The pins are passed as a pin mask, so there is no ordering, and therefore the pins must be given in ascending order else the names will be associated with the wrong pins This breaks compilation of the pio/spi/spi_flash example, as the pins there are not in order - given the default pins could be in any order depending on the board, that example should probably be modified to have 4 separate `bi_1pin_with_name` lines instead of a single `bi_4pins_with_names`

lurch commented

2024-08-21 06:20:19 -05:00

(Migrated from github.com)

Huhhh. Rather than break the "external API", I guess a better approach might be to reorder the names so that they're in the same order as the pins? Put perhaps the usage of macros instead of functions means that you can't do that? 🤔

Rows
Columns

Assert ordering of pins in bi_pins_with_names is correct #1791

Pull request closed