support both struct timespec and struct tm variants of the aon timer APIs #2079
No reviewers
Labels
No labels
bazel
bluetooth
board settings
boot_stage2
bug
build
c++
can't reproduce
clang
clib-interface
cmsis
code cleanliness
code size
compiler version issues
cyw43_driver
debug
discussion
documentation
duplicate
dynamic_clock
elf2uf2
enhancement
errata
filesystem
flash layout
floating point
FreeRTOS
hardware_adc
hardware_claim
hardware_clocks
hardware_dma
hardware_exception
hardware_flash
hardware_gpio
hardware_i2c
hardware_irq
hardware_pio
hardware_pwm
hardware_rcp
hardware_rtc
hardware_spi
hardware_sync
hardware_uart
hardware_vreg
hardware_watchdog
hardware_xosc
help wanted
host
IAR
installation
invalid
linker scripts
lto
lwip
mbedtls
missing API
needs reporter detail
networking
newlib
newlib-multicore
non-c
non-cmake
non-gcc
openocd
orphan PR
OS integration
pico_async_context
pico_base
pico_binary_info
pico_flash
picolibc
pico_lwip
pico_malloc
pico_multicore
pico_printf
pico_runtime
pico_stdio
pico_stdio_usb
pico_sync
pico_time
pico_util
pioasm
port
question
review
review2
rtos interop
runtime init
static library
svd
test
tinyusb
vscode
wifi integration
wontfix
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
gh-raspberrypi/pico-sdk!2079
Loading…
Reference in a new issue
No description provided.
Delete branch "aon_timer_clib"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
… since use of one type on RP2040 and the other on RP2350 require pulling in C library code.
Also provide weak
pico_wrappers forlocaltime_randmktimeso that the user can override the conversion functionsfixes #1810
@ -4,0 +8,4 @@#endif__datetime_weak struct tm * pico_localtime_r(const time_t *time, struct tm *tm) {return localtime_r(time, tm);This is in the right place this time? It looks like you moved it back.
@ -23,6 +23,38 @@* \if rp2350_specificI don't really understand what it means by "non date/time methods" here
@ -23,6 +23,38 @@* \if rp2350_specificmaybe a list of the methods that are affected by the clib overhead in 2040 and 2350 (a different set?) would be useful?
@ -23,56 +24,92 @@ static void powman_timer_irq_handler(void) {irq_remove_handler(irq_num, powman_timer_irq_handler);if (aon_timer_alarm_handler) aon_timer_alarm_handler();}This isn't working. Don't you have to convert the ts to a tm AFTER the call to aon_timer_get_time?
@ -23,6 +23,38 @@* \if rp2350_specificcan you suggest a clarification - this refers very much to the previous paragraph (i could add "calendar" here)
I suppose we could list them all
@ -23,56 +24,92 @@ static void powman_timer_irq_handler(void) {irq_remove_handler(irq_num, powman_timer_irq_handler);if (aon_timer_alarm_handler) aon_timer_alarm_handler();}ha oops