Add board file for Pimoroni Pico Plus 2 W #2092

2024-11-23T23:09:10-06:00

gonzalolarralde commented

2024-11-23 23:09:10 -06:00

(Migrated from github.com)

See the board details here: Pimoroni Pico Plus 2 W

This board is similar to pimoroni_pico_plus2_rp2350. I cannot reuse the same header file as this one does not have a direct wire to the LED, similar to pico_w it depends on the WiFi chip for it (compatibility, presumably).

I have no affiliation with Pimoroni, I just purchased a board and I'm using it with this modifications. I see that @ZodiusInfuser has posted some PRs for Pimoroni boards in the past so maybe they can chime in for review?

Fixes #2091

Thanks!

See the board details here: [Pimoroni Pico Plus 2 W](https://shop.pimoroni.com/products/pimoroni-pico-plus-2-w?variant=42182811942995) This board is similar to pimoroni_pico_plus2_rp2350. I cannot reuse the same header file as this one does not have a direct wire to the LED, similar to pico_w it depends on the WiFi chip for it (compatibility, presumably). I have no affiliation with Pimoroni, I just purchased a board and I'm using it with this modifications. I see that @ZodiusInfuser has posted some PRs for Pimoroni boards in the past so maybe they can chime in for review? Fixes #2091 Thanks!

🎉 1

kilograham (Migrated from github.com) reviewed

2024-11-24 11:18:47 -06:00

src/boards/include/boards/pimoroni_pico_plus2_w_rp2350.h

					
				@ -0,0 +1,143 @@

				/*

any reason these aren't PLUS2_W? not sure who uses them!

peterharperuk commented

2024-11-24 11:22:06 -06:00

(Migrated from github.com)

@Gadgetoid

kilograham (Migrated from github.com) reviewed

2024-11-24 11:56:34 -06:00

src/boards/include/boards/pimoroni_pico_plus2_w_rp2350.h

					
				@ -0,0 +1,143 @@

				/*

Note these are now SPCE_ in other pimoroni board headers

lurch (Migrated from github.com) reviewed

2024-11-24 17:52:37 -06:00

src/boards/include/boards/pimoroni_pico_plus2_w_rp2350.h

					
				@ -0,0 +1,143 @@

				/*

(see #2048 )

lurch commented

2024-11-24 18:15:59 -06:00

(Migrated from github.com)

This is missing a // pico_cmake_set_default PICO_RP2350_A2_SUPPORTED line (which https://github.com/raspberrypi/pico-sdk/blob/develop/src/boards/include/boards/pimoroni_pico_plus2_rp2350.h does have).

Seems unlikely that PICO_VBUS_PIN and CYW43_PIN_WL_HOST_WAKE are both on pin 24?

Comparing this to https://github.com/raspberrypi/pico-sdk/blob/develop/src/boards/include/boards/pico2_w.h , this seem to be missing CYW43_DEFAULT_PIN_WL_DATA_OUT, CYW43_DEFAULT_PIN_WL_DATA_IN, etc.?

This is missing a `// pico_cmake_set_default PICO_RP2350_A2_SUPPORTED` line (which https://github.com/raspberrypi/pico-sdk/blob/develop/src/boards/include/boards/pimoroni_pico_plus2_rp2350.h **does** have). Seems unlikely that `PICO_VBUS_PIN` and `CYW43_PIN_WL_HOST_WAKE` are both on pin 24? Comparing this to https://github.com/raspberrypi/pico-sdk/blob/develop/src/boards/include/boards/pico2_w.h , this seem to be missing `CYW43_DEFAULT_PIN_WL_DATA_OUT`, `CYW43_DEFAULT_PIN_WL_DATA_IN`, etc.?

kilograham (Migrated from github.com) reviewed

2024-11-24 19:44:02 -06:00

kilograham (Migrated from github.com) left a comment

No description provided.

Going to merge this as is for 2.1.0 release; it's likely better than nothing

kilograham commented

2024-11-24 19:44:19 -06:00

(Migrated from github.com)

This is missing a // pico_cmake_set_default PICO_RP2350_A2_SUPPORTED line (which https://github.com/raspberrypi/pico-sdk/blob/develop/src/boards/include/boards/pimoroni_pico_plus2_rp2350.h does have).

Seems unlikely that PICO_VBUS_PIN and CYW43_PIN_WL_HOST_WAKE are both on pin 24?

Comparing this to https://github.com/raspberrypi/pico-sdk/blob/develop/src/boards/include/boards/pico2_w.h , this seem to be missing CYW43_DEFAULT_PIN_WL_DATA_OUT, CYW43_DEFAULT_PIN_WL_DATA_IN, etc.?

fixed all of these

> This is missing a `// pico_cmake_set_default PICO_RP2350_A2_SUPPORTED` line (which https://github.com/raspberrypi/pico-sdk/blob/develop/src/boards/include/boards/pimoroni_pico_plus2_rp2350.h **does** have). > > Seems unlikely that `PICO_VBUS_PIN` and `CYW43_PIN_WL_HOST_WAKE` are both on pin 24? > > Comparing this to https://github.com/raspberrypi/pico-sdk/blob/develop/src/boards/include/boards/pico2_w.h , this seem to be missing `CYW43_DEFAULT_PIN_WL_DATA_OUT`, `CYW43_DEFAULT_PIN_WL_DATA_IN`, etc.? fixed all of these

🎉 1

gonzalolarralde commented

2024-11-24 19:44:24 -06:00

(Migrated from github.com)

Thanks, I initially did this off picoroni_pico_plus2_rp2350.h on main, that's why a few things are off. I was completing the changes but seems like @kilograham took a pass on them.

Thanks, I initially did this off `picoroni_pico_plus2_rp2350.h` on main, that's why a few things are off. I was completing the changes but seems like @kilograham took a pass on them.

kilograham commented

2024-11-24 19:45:32 -06:00

(Migrated from github.com)

Ah yes, please review my latest change, as I'm about to merge to catch 2.1.0 release

🚀 1

gonzalolarralde commented

2024-11-24 19:52:34 -06:00

(Migrated from github.com)

@kilograham checking the first few defines, the SPCE connector is not present in the Plus 2 W.

These should be removed

#define SPCE_TX_MISO_PIN 32
#define SPCE_RX_CS_PIN 33
#define SPCE_NETLIGHT_SCK_PIN 34
#define SPCE_RESET_MOSI_PIN 35
#define SPCE_PWRKEY_BL_PIN 36

These are OK

#define PIMORONI_PICO_PLUS2_W_USER_SW_PIN 45
#define PIMORONI_PICO_PLUS2_W_PSRAM_CS_PIN 47

@kilograham checking the first few defines, the SPCE connector is not present in the Plus 2 W. These should be removed ``` #define SPCE_TX_MISO_PIN 32 #define SPCE_RX_CS_PIN 33 #define SPCE_NETLIGHT_SCK_PIN 34 #define SPCE_RESET_MOSI_PIN 35 #define SPCE_PWRKEY_BL_PIN 36 ``` These are OK ``` #define PIMORONI_PICO_PLUS2_W_USER_SW_PIN 45 #define PIMORONI_PICO_PLUS2_W_PSRAM_CS_PIN 47 ```

kilograham commented

2024-11-24 19:54:46 -06:00

(Migrated from github.com)

ah, then can you remove them and fix up the SPI pins to be correct

gonzalolarralde commented

2024-11-24 19:55:49 -06:00

(Migrated from github.com)

@kilograham done. can you check if it looks fine for you?

kilograham commented

2024-11-24 20:02:00 -06:00

(Migrated from github.com)

You say "default SPI to the same as pico2_w" ... no reason to assume that they are the same as Pico2 W - are there any SPI pins exposed on the Pico Plus 2 W? I don't have the schematic

kilograham commented

2024-11-24 20:04:11 -06:00

(Migrated from github.com)

actually i looked on the website and this seems reasonable; i'm gonna merge

gonzalolarralde commented

2024-11-24 20:32:32 -06:00

(Migrated from github.com)

@kilograham great, thanks for pushing this through!

Gadgetoid commented

2024-11-25 03:45:11 -06:00

(Migrated from github.com)

Thanks for jumping on this, and nice timing.

I got a bit too caught up getting the wireless stuff working in MicroPython and trying to get a single build for our W and "non-W" variants. (Since both support wireless in theory)

Thanks for jumping on this, and nice timing. I got a bit too caught up getting the wireless stuff working in MicroPython and trying to get a single build for our W and "non-W" variants. (Since both support wireless in theory)

🚀 1

Sign in to join this conversation.

No reviewers