gh-raspberrypi/pico-sdk

Watch

Add some extra defines to customise behaviour of STDIO_USB_RESET modes #226

Merged

lurch merged 2 commits from usb_reset_options into develop

2021-03-04 19:01:30 -06:00

lurch commented

2021-03-04 10:59:57 -06:00

(Migrated from github.com)

I think I've got this right, but you'll obviously want to review it quite carefully @kilograham

I've tested the defines in combination with VIA_BAUD_RATE and they all work fine, but I've been unable to test with VIA_VENDOR_INTERFACE.

I _think_ I've got this right, but you'll obviously want to review it quite carefully @kilograham I've tested the defines in combination with VIA_BAUD_RATE and they all work fine, but I've been unable to test with VIA_VENDOR_INTERFACE.

kilograham (Migrated from github.com) requested changes

2021-03-04 12:56:43 -06:00

src/rp2_common/pico_bootsel_via_double_reset/pico_bootsel_via_double_reset.c

					
				@ -14,12 +14,9 @@

				#define PICO_BOOTSEL_VIA_DOUBLE_RESET_TIMEOUT_MS 200

i think we should actually switch to using undefined rather than -1 now to match regular LED

i think we should actually switch to using undefined rather than -1 now to match regular LED

src/rp2_common/pico_stdio_usb/include/pico/stdio_usb.h

					
				@ -54,6 +54,19 @@

				#define PICO_STDIO_USB_RESET_MAGIC_BAUD_RATE 1200

so again get rid of the -1 and use undefined, and split the -2 off into a separate define to disallow overriding the value via the reset interface

so again get rid of the -1 and use undefined, and split the -2 off into a separate define to disallow overriding the value via the reset interface

lurch (Migrated from github.com) reviewed

2021-03-04 13:57:21 -06:00

src/rp2_common/pico_stdio_usb/include/pico/stdio_usb.h

					
				@ -54,6 +54,19 @@

				#define PICO_STDIO_USB_RESET_MAGIC_BAUD_RATE 1200

I think I've done what you were asking for 🙂

I think I've done what you were asking for :slightly_smiling_face:

kilograham (Migrated from github.com) approved these changes

2021-03-04 19:00:35 -06:00

kilograham (Migrated from github.com) approved these changes

2021-03-04 19:01:26 -06:00

kilograham (Migrated from github.com) left a comment

I would have added a static inline function for getting the pin mask, but not reason enough to change at this second

I would have added a static inline function for getting the pin mask, but not reason enough to change at this second

Sign in to join this conversation.

No reviewers

No labels

can't reproduce

code cleanliness

compiler version issues

hardware_clocks

hardware_exception

hardware_watchdog

needs reporter detail

newlib-multicore

pico_async_context

pico_binary_info

wifi integration

No milestone

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

gh-raspberrypi/pico-sdk!226

No description provided.