RP2040 and RP2350 have different maximum watchdog delays #2500

Merged
lurch merged 1 commit from lurch-patch-1 into develop 2025-06-12 17:43:53 -05:00
lurch commented 2025-06-02 16:34:02 -05:00 (Migrated from github.com)

RP2040-E1 doesn't apply to RP2350 😉 I spotted this whilst investigating #2497

RP2040-E1 doesn't apply to RP2350 :wink: I spotted this whilst investigating #2497
peterharperuk (Migrated from github.com) reviewed 2025-06-03 04:05:08 -05:00
@ -74,6 +74,13 @@ void watchdog_update(void);
* \note If \ref watchdog_start_tick value does not give a 1MHz clock to the watchdog system, then the \p delay_ms
peterharperuk (Migrated from github.com) commented 2025-06-03 04:05:08 -05:00

spelling

spelling
peterharperuk (Migrated from github.com) reviewed 2025-06-03 04:05:23 -05:00
@ -74,6 +74,13 @@ void watchdog_update(void);
* \note If \ref watchdog_start_tick value does not give a 1MHz clock to the watchdog system, then the \p delay_ms
peterharperuk (Migrated from github.com) commented 2025-06-03 04:05:23 -05:00

ditton

ditton
peterharperuk (Migrated from github.com) reviewed 2025-06-03 04:05:51 -05:00
@ -74,6 +74,13 @@ void watchdog_update(void);
* \note If \ref watchdog_start_tick value does not give a 1MHz clock to the watchdog system, then the \p delay_ms
peterharperuk (Migrated from github.com) commented 2025-06-03 04:05:51 -05:00

Maybe reference the errata?

Maybe reference the errata?
lurch (Migrated from github.com) reviewed 2025-06-03 04:27:39 -05:00
@ -74,6 +74,13 @@ void watchdog_update(void);
* \note If \ref watchdog_start_tick value does not give a 1MHz clock to the watchdog system, then the \p delay_ms
lurch (Migrated from github.com) commented 2025-06-03 04:27:39 -05:00

🤦‍♂️ I guess that's what happens when I make late-night PRs!

:man_facepalming: I guess that's what happens when I make late-night PRs!
lurch (Migrated from github.com) reviewed 2025-06-03 06:05:25 -05:00
@ -74,6 +74,13 @@ void watchdog_update(void);
* \note If \ref watchdog_start_tick value does not give a 1MHz clock to the watchdog system, then the \p delay_ms
lurch (Migrated from github.com) commented 2025-06-03 06:05:25 -05:00

In fairness, I'd made the typo by copy'n'pasting an existing typo in the same header-file 😂

In fairness, I'd made the typo by copy'n'pasting an existing typo in the same header-file :joy:
lurch commented 2025-06-03 06:06:45 -05:00 (Migrated from github.com)

Updated and force-pushed

Updated and force-pushed
lurch (Migrated from github.com) reviewed 2025-06-03 06:11:37 -05:00
lurch (Migrated from github.com) commented 2025-06-03 06:11:36 -05:00

@kilograham Do you know which hardware bug this is referring to? The RP2040 datasheet lists RP2040-E1 (which doesn't cover this) as the only watchdog-related errata.

@kilograham Do you know which hardware bug this is referring to? The RP2040 datasheet lists RP2040-E1 (which doesn't cover this) as the only watchdog-related errata.
lurch (Migrated from github.com) reviewed 2025-06-03 11:37:38 -05:00
lurch (Migrated from github.com) commented 2025-06-03 11:37:38 -05:00

Seems like I'd forgotten about #1492 🤦

Seems like I'd forgotten about #1492 :facepalm:
peterharperuk (Migrated from github.com) approved these changes 2025-06-05 10:21:15 -05:00
peterharperuk (Migrated from github.com) left a comment

This seems a bit better

This seems a bit better
Sign in to join this conversation.
No reviewers
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-raspberrypi/pico-sdk!2500
No description provided.