add 2 shared irq handlers when using stdio_usb #3037
No reviewers
Labels
No labels
bazel
bluetooth
board settings
boot_stage2
bug
build
c++
can't reproduce
clang
clib-interface
cmsis
code cleanliness
code size
compiler version issues
cyw43_driver
debug
discussion
documentation
duplicate
dynamic_clock
elf2uf2
enhancement
errata
filesystem
flash layout
floating point
FreeRTOS
hardware_adc
hardware_claim
hardware_clocks
hardware_dma
hardware_exception
hardware_flash
hardware_gpio
hardware_i2c
hardware_irq
hardware_pio
hardware_pwm
hardware_rcp
hardware_rtc
hardware_spi
hardware_sync
hardware_uart
hardware_vreg
hardware_watchdog
hardware_xosc
help wanted
host
IAR
installation
invalid
linker scripts
lto
lwip
mbedtls
missing API
needs reporter detail
networking
newlib
newlib-multicore
non-c
non-cmake
non-gcc
openocd
orphan PR
OS integration
pico_async_context
pico_base
pico_binary_info
pico_flash
picolibc
pico_lwip
pico_malloc
pico_multicore
pico_printf
pico_runtime
pico_stdio
pico_stdio_usb
pico_sync
pico_time
pico_util
pioasm
port
question
review
review2
rtos interop
runtime init
static library
svd
test
tinyusb
vscode
wifi integration
wontfix
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
gh-raspberrypi/pico-sdk!3037
Loading…
Reference in a new issue
No description provided.
Delete branch "shared-irq-handlers"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
note i didn't add a new config option to turn this off, since you can just set PICO_MAX_SHARED_IRQ_HANDLERS if you actually really care
note i didn't add more on rp2350 by default, as no one else has complained
fixes #2732
@ -8,9 +8,14 @@#define _HARDWARE_IRQ_H// These two config items are also used by assembler, so keeping separate@ -8,9 +8,14 @@#define _HARDWARE_IRQ_H// These two config items are also used by assembler, so keeping separateIt might be better phrased something like “4 available for use plus 2 used by stdio_usb if that is in use”? Probably with less clunky wording than mine
@ -8,9 +8,14 @@#define _HARDWARE_IRQ_H// These two config items are also used by assembler, so keeping separateHmmm, maybe "6 if using stdio_usb (with 2 of those used by stdio_usb itself) otherwise 4" ? 🤷
(I'm just kinda guessing here as I don't really understand this shared IRQ handlers stuff)
One comment, but approving anyway, as it's good enough without addressing that
@ -10,3 +10,3 @@// These two config items are also used by assembler, so keeping separate// PICO_CONFIG: PICO_MAX_SHARED_IRQ_HANDLERS, Maximum number of shared IRQ handlers, default=4, advanced=true, group=hardware_irq// PICO_CONFIG: PICO_MAX_SHARED_IRQ_HANDLERS, Maximum number of shared IRQ handlers, default=6 if using stdio_usb otherwise 4, advanced=true, group=hardware_irq#ifndef PICO_MAX_SHARED_IRQ_HANDLERSMaybe this could do with some better clarification that you're not getting extra shared IRQ handlers to use when you're using stdio_usb, the number is just being increased so stdio_usb still leaves you with 4 handlers to use?
@ -10,3 +10,3 @@// These two config items are also used by assembler, so keeping separate// PICO_CONFIG: PICO_MAX_SHARED_IRQ_HANDLERS, Maximum number of shared IRQ handlers, default=4, advanced=true, group=hardware_irq// PICO_CONFIG: PICO_MAX_SHARED_IRQ_HANDLERS, Maximum number of shared IRQ handlers, default=6 if using stdio_usb otherwise 4, advanced=true, group=hardware_irq#ifndef PICO_MAX_SHARED_IRQ_HANDLERSfeel free to PR