Bazel build path bug fix #3067
No reviewers
Labels
No labels
bazel
bluetooth
board settings
boot_stage2
bug
build
c++
can't reproduce
clang
clib-interface
cmsis
code cleanliness
code size
compiler version issues
cyw43_driver
debug
discussion
documentation
duplicate
dynamic_clock
elf2uf2
enhancement
errata
filesystem
flash layout
floating point
FreeRTOS
hardware_adc
hardware_claim
hardware_clocks
hardware_dma
hardware_exception
hardware_flash
hardware_gpio
hardware_i2c
hardware_irq
hardware_pio
hardware_pwm
hardware_rcp
hardware_rtc
hardware_spi
hardware_sync
hardware_uart
hardware_vreg
hardware_watchdog
hardware_xosc
help wanted
host
IAR
installation
invalid
linker scripts
lto
lwip
mbedtls
missing API
needs reporter detail
networking
newlib
newlib-multicore
non-c
non-cmake
non-gcc
openocd
orphan PR
OS integration
pico_async_context
pico_base
pico_binary_info
pico_flash
picolibc
pico_lwip
pico_malloc
pico_multicore
pico_printf
pico_runtime
pico_stdio
pico_stdio_usb
pico_sync
pico_time
pico_util
pioasm
port
question
review
review2
rtos interop
runtime init
static library
svd
test
tinyusb
vscode
wifi integration
wontfix
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
gh-raspberrypi/pico-sdk!3067
Loading…
Reference in a new issue
No description provided.
Delete branch "pico_usb_reset_bug"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The src/rp2_common/pico_usb_reset_interface was renamed to src/rp2_common/pico_usb_reset but it was not reflected in the bazel build file. This patch addresses it.
Fixes #3066
Looks like this was changed in #2629
@will-v-pi How come this wasn't picked up by any of our automated tests?
Presumably the Bazel tests have never tested stdio_usb - @Prabhuk could you add a test as part of this PR or separately (probably another pico_stdio_test) which would fail without this fix?
Ironically it looks like the Bazel CI checks are now failing for a different reason 😉
ping @armandomontanez
Latest Picotool hasn't been released to the BCR. Let me send that out.
https://github.com/bazelbuild/bazel-central-registry/pull/9619