gh-raspberrypi/pico-sdk

Watch

Fork 0

Add check_riscv_flag_pick CI check #3136

Open

will-v-pi wants to merge 3 commits from riscv-flag-check into develop

will-v-pi commented

2026-08-14 09:19:52 -05:00

(Migrated from github.com)

Checks that the Risc-V flag selection chooses the correct flags for known compilers

This should catch the 2.3.0 issue that was fixed in https://github.com/raspberrypi/pico-sdk/pull/3076, where it fell through to the non-zcmp arch on a zcmp compiler

Checks that the Risc-V flag selection chooses the correct flags for known compilers This should catch the 2.3.0 issue that was fixed in https://github.com/raspberrypi/pico-sdk/pull/3076, where it fell through to the non-zcmp arch on a zcmp compiler

lurch (Migrated from github.com) reviewed

2026-08-21 11:12:54 -05:00

.github/workflows/check_riscv_flag_pick.yml

name: Check RISC-V flag choices

```suggestion name: Check RISC-V flag choices ```

lurch (Migrated from github.com) reviewed

2026-08-21 11:33:13 -05:00

.github/workflows/check_riscv_flag_pick.yml

Alternatively:

        rm -rf build && mkdir build
        cmake -S . -B build -DPICO_NO_PICOTOOL=1 -DPICO_PLATFORM=rp2350-riscv -DPICO_TOOLCHAIN_PATH=/opt/riscv/gcc-riscv-32-pico-elf-16.1.0
        grep "CMAKE_ASM_FLAGS" build/CMakeCache.txt
        grep "cpu=hazard3-rp2350" build/CMakeCache.txt

Alternatively: ```suggestion rm -rf build && mkdir build cmake -S . -B build -DPICO_NO_PICOTOOL=1 -DPICO_PLATFORM=rp2350-riscv -DPICO_TOOLCHAIN_PATH=/opt/riscv/gcc-riscv-32-pico-elf-16.1.0 grep "CMAKE_ASM_FLAGS" build/CMakeCache.txt grep "cpu=hazard3-rp2350" build/CMakeCache.txt ```

lurch commented

2026-08-21 11:41:13 -05:00

(Migrated from github.com)

Hmmm, I guess there's probably not much value in running this on every single CI run, so perhaps this is worth adding to https://github.com/raspberrypi/pico-sdk/blob/develop/.github/workflows/multi-gcc.yml instead, and maybe that'd also make it more likely that these RISC-V compiler-tests get updated as and when we add new compiler-versions into the mix? 🤔

Hmmm, I guess there's probably not much value in running this on every single CI run, so perhaps this is worth adding to https://github.com/raspberrypi/pico-sdk/blob/develop/.github/workflows/multi-gcc.yml instead, and _maybe_ that'd also make it more likely that these RISC-V compiler-tests get updated as and when we add new compiler-versions into the mix? :thinking:

will-v-pi (Migrated from github.com) reviewed

2026-08-24 05:25:46 -05:00

.github/workflows/check_riscv_flag_pick.yml

The mkdir build can go too, as cmake will create the directory - I'll apply manually

The `mkdir build` can go too, as cmake will create the directory - I'll apply manually

will-v-pi commented

2026-08-24 05:44:00 -05:00

(Migrated from github.com)

I've moved it into multi-gcc, and kicked off a run https://github.com/raspberrypi/pico-sdk/actions/runs/32718183803/job/97403804842

❤️ 1

This pull request can be merged automatically.

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin 'riscv-flag-check:riscv-flag-check'

git switch 'riscv-flag-check'

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch 'develop'

git merge --no-ff 'riscv-flag-check'

git switch 'riscv-flag-check'

git rebase 'develop'

git switch 'develop'

git merge --ff-only 'riscv-flag-check'

git switch 'riscv-flag-check'

git rebase 'develop'

git switch 'develop'

git merge --no-ff 'riscv-flag-check'

git switch 'develop'

git merge --squash 'riscv-flag-check'