Don't copy/paste code into sync/time test cases #3151

2026-08-20T18:47:36-05:00

kilograham commented

2026-08-20 18:47:36 -05:00

(Migrated from github.com)

add blocked_waiter_wakeup() to time/sync primitives.
rework test-case to use vs copy/paste
fixel bazel compile flags.
add PICO_PLATFORM_TEST_HEADER for test injections

* add blocked_waiter_wakeup() to time/sync primitives. * rework test-case to use vs copy/paste * fixel bazel compile flags. * add PICO_PLATFORM_TEST_HEADER for test injections

will-v-pi (Migrated from github.com) reviewed

2026-08-20 18:47:36 -05:00

Wren6991 (Migrated from github.com) reviewed

2026-08-20 19:19:53 -05:00

Wren6991 commented

2026-08-20 19:21:32 -05:00

(Migrated from github.com)

Context: final lingering issue from #3127

lurch commented

2026-08-21 09:09:33 -05:00

(Migrated from github.com)

Bazel CI checks are failing 🙁

[WARNING] Files not included in the Bazel build:

  test/pico_sync_test/pico_sync_test_hook.h
  test/sync_interop_test/interop_test_hook.h

[ERROR] Missing files found.

Bazel CI checks are failing :slightly_frowning_face: ``` [WARNING] Files not included in the Bazel build: test/pico_sync_test/pico_sync_test_hook.h test/sync_interop_test/interop_test_hook.h [ERROR] Missing files found. ```

lurch (Migrated from github.com) reviewed

2026-08-21 10:37:00 -05:00

test/sync_interop_test/interop_platform.c

					
				@ -58,2 +55,2 @@

				    } while (true);

				    return waits;

				    interop_sleep_mark[get_core_num()] = harness_sleep_counter();

				    interop_wakeups[get_core_num()] = 0;

I guess this could do

    uint core = get_core_num();
    inline_wait_sleep_delta = 0;
    interop_sleep_mark[core] = harness_sleep_counter();
    interop_wakeups[core] = 0;

to make this more similar to interop_wait_wakeup ?

I guess this could do ```c uint core = get_core_num(); inline_wait_sleep_delta = 0; interop_sleep_mark[core] = harness_sleep_counter(); interop_wakeups[core] = 0; ``` to make this more similar to `interop_wait_wakeup` ?

Sign in to join this conversation.

No reviewers

will-v-pi