gh-raspberrypi/pico-sdk

Watch

add cytron motion 2350 pro board #3154

Merged

ItsJupiter21 merged 2 commits from add-motion-2350 into develop

2026-09-03 09:12:30 -05:00

ItsJupiter21 commented

2026-08-21 20:45:20 -05:00

(Migrated from github.com)

Adds the cytron motion 2350 board.

pinout:

datasheet:
https://docs.google.com/document/d/1qYD0RdZG1tiklflnt8Z7jBy-wUJ3LbNBJ4aT1EgnjqQ/edit?usp=sharing

tools/check_board_header.py src/boards/include/boards/cytron_motion_2350_pro.h runs without errors.

Adds the cytron motion 2350 board. pinout: <img width="3508" height="2481" alt="image" src="https://github.com/user-attachments/assets/47061362-c6cd-4395-853b-b3c5718564c3" /> datasheet: https://docs.google.com/document/d/1qYD0RdZG1tiklflnt8Z7jBy-wUJ3LbNBJ4aT1EgnjqQ/edit?usp=sharing `tools/check_board_header.py src/boards/include/boards/cytron_motion_2350_pro.h` runs without errors.

lurch (Migrated from github.com) reviewed

2026-08-22 08:46:24 -05:00

src/boards/include/boards/cytron_motion_2350_pro.h

					
				@ -0,0 +26,4 @@

				// --- BOARD SPECIFIC ---

				// Motor drivers

				#ifndef MOTION_2350_PRO_M1A_PIN

I'm not sure if these board-specific pins need to be inside #ifndef guards, because it seems pretty unlikely that a user would reassign e.g. MOTION_2350_PRO_M1A_PIN to a different pin-number? 🤔

I'm not sure if these board-specific pins need to be inside `#ifndef` guards, because it seems pretty unlikely that a user would reassign e.g. `MOTION_2350_PRO_M1A_PIN` to a different pin-number? :thinking:

lurch (Migrated from github.com) reviewed

2026-08-22 08:53:48 -05:00

src/boards/include/boards/cytron_motion_2350_pro.h

					
				@ -0,0 +105,4 @@

				// This board has two WS2812 leds in series

				#ifndef PICO_DEFAULT_WS2812_NUM_PIXELS

				#define PICO_DEFAULT_WS2812_NUM_PIXELS 2

				#endif

Interesting. @peterharperuk How does your status_led code behave if there's two WS2812 LEDs connected to PICO_DEFAULT_WS2812_PIN ? (Does only the first LED change colour, do both LEDs change colour, or do any colour-changes end up getting cascaded down the chain?)

Interesting. @peterharperuk How does your status_led code behave if there's two WS2812 LEDs connected to `PICO_DEFAULT_WS2812_PIN` ? (Does only the first LED change colour, do both LEDs change colour, or do any colour-changes end up getting cascaded down the chain?)

ItsJupiter21 (Migrated from github.com) reviewed

2026-08-22 08:58:23 -05:00

src/boards/include/boards/cytron_motion_2350_pro.h

					
				@ -0,0 +26,4 @@

				// --- BOARD SPECIFIC ---

				// Motor drivers

				#ifndef MOTION_2350_PRO_M1A_PIN

I copied this behaviour from the maker pi: https://github.com/raspberrypi/pico-sdk/blob/master/src/boards/include/boards/cytron_maker_pi_rp2040.h , i can remove the guards if thatd be better

I copied this behaviour from the maker pi: https://github.com/raspberrypi/pico-sdk/blob/master/src/boards/include/boards/cytron_maker_pi_rp2040.h , i can remove the guards if thatd be better

lurch commented

2026-08-22 08:58:54 -05:00

(Migrated from github.com)

Looking at your pinout diagram, is it worth also adding some #define values for the buzzer and the "maker ports"?

Looking at your pinout diagram, is it worth also adding some `#define` values for the buzzer and the "maker ports"?

ItsJupiter21 commented

2026-08-22 09:10:51 -05:00

(Migrated from github.com)

Added the buzzer pin. Dont think there's any value in adding the maker ports since they're only labelled with the pin numbers.

Added the buzzer pin. Dont think there's any value in adding the maker ports since they're only labelled with the pin numbers.

lurch (Migrated from github.com) reviewed

2026-08-24 07:42:40 -05:00

src/boards/include/boards/cytron_motion_2350_pro.h

					
				@ -0,0 +26,4 @@

				// --- BOARD SPECIFIC ---

				// Motor drivers

				#ifndef MOTION_2350_PRO_M1A_PIN

I personally don't think that they're needed, but they obviously don't do any harm, so I'm happy to leave them in there.

I _personally_ don't think that they're needed, but they obviously don't do any harm, so I'm happy to leave them in there.

lurch (Migrated from github.com) approved these changes

2026-08-24 08:04:05 -05:00

peterharperuk (Migrated from github.com) reviewed

2026-08-24 08:25:06 -05:00

src/boards/include/boards/cytron_motion_2350_pro.h

					
				@ -0,0 +105,4 @@

				// This board has two WS2812 leds in series

				#ifndef PICO_DEFAULT_WS2812_NUM_PIXELS

				#define PICO_DEFAULT_WS2812_NUM_PIXELS 2

				#endif

No sure - I'd have to test it. This might be the first board that doesn't define a separate LED pin?

No sure - I'd have to test it. This might be the first board that doesn't define a separate LED pin?

peterharperuk (Migrated from github.com) reviewed

2026-08-24 08:49:29 -05:00

src/boards/include/boards/cytron_motion_2350_pro.h

					
				@ -0,0 +105,4 @@

				// This board has two WS2812 leds in series

				#ifndef PICO_DEFAULT_WS2812_NUM_PIXELS

				#define PICO_DEFAULT_WS2812_NUM_PIXELS 2

				#endif

Seems to behave fine

Seems to behave fine

Sign in to join this conversation.

No reviewers

No labels

can't reproduce

code cleanliness

compiler version issues

hardware_clocks

hardware_exception

hardware_watchdog

needs reporter detail

newlib-multicore

pico_async_context

pico_binary_info

wifi integration

No milestone

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

gh-raspberrypi/pico-sdk!3154

No description provided.