Various fixes to co-exist with newest TinyUSB #3163

Merged
kilograham merged 3 commits from latest-tinyusb-support into develop 2026-09-02 13:53:24 -05:00
kilograham commented 2026-08-29 18:34:12 -05:00 (Migrated from github.com)

if some project calls it expecting it to be there, it needs to be there!

if some project calls it expecting it to be there, it needs to be there!
will-v-pi (Migrated from github.com) reviewed 2026-09-01 04:20:29 -05:00
will-v-pi (Migrated from github.com) commented 2026-09-01 04:20:29 -05:00

Should we still add our extra suppressions here, or do those warnings not appear in tinyusb versions without this function?

Should we still add our extra suppressions here, or do those warnings not appear in tinyusb versions without this function?
kilograham (Migrated from github.com) reviewed 2026-09-01 16:39:56 -05:00
kilograham (Migrated from github.com) commented 2026-09-01 16:39:56 -05:00

I thought they were resolved, which is why i did it like this, but actually still working on checking!

I thought they were resolved, which is why i did it like this, but actually still working on checking!
peterharperuk commented 2026-09-02 05:07:53 -05:00 (Migrated from github.com)

I've tested this. The only problem I see now is if I update tinyusb to 0.21.0 and run lib/tinyusb/tools/get_deps.py I am now getting a build error...

cd /home/peterh/source/pico-examples1/build/usb/device/tinyusb_device_examples/audio_4_channel_mic && python -j /home/peterh/source/pico-examples1/build/usb/device/tinyusb_device_examples/audio_4_channel_mic/audio_4_channel_mic.elf.map
Unknown option: -j
usage: python [option] ... [-c cmd | -m mod | file | -] [arg] ...
Try `python -h' for more information.
make[2]: *** [usb/device/tinyusb_device_examples/audio_4_channel_mic/CMakeFiles/audio_4_channel_mic.dir/build.make:1509: usb/device/tinyusb_device_examples/audio_4_channel_mic/audio_4_channel_mic.elf] Error 2

Not sure why I didn't see this before. It's something to do with family_add_linkermap, LINKERMAP_PY is empty

CMake Error at /home/peterh/source/pico-sdk1/lib/tinyusb/hw/bsp/family_support.cmake:264 (message):
  why isn't LINKERMAP_PY defined?
Call Stack (most recent call first):
  /home/peterh/source/pico-sdk1/lib/tinyusb/hw/bsp/family_support.cmake:527 (family_add_linkermap)
  /home/peterh/source/pico-sdk1/lib/tinyusb/hw/bsp/rp2040/family.cmake:248 (family_configure_common)
  /home/peterh/source/pico-sdk1/lib/tinyusb/hw/bsp/rp2040/family.cmake:261 (family_configure_example)
  /home/peterh/source/pico-sdk1/lib/tinyusb/examples/device/audio_4_channel_mic/CMakeLists.txt:35 (family_configure_device_example)

For some reason - my fix work ok https://github.com/raspberrypi/pico-examples/pull/778

later: The develop version of pico-examples resets LINKERMAP_PY which goes out of scope - but your PR removes this https://github.com/raspberrypi/pico-examples/pull/787. So I think that's a different issue and this pico-sdk PR is ok.

I've tested this. The only problem I see now is if I update tinyusb to 0.21.0 and run lib/tinyusb/tools/get_deps.py I am now getting a build error... ``` cd /home/peterh/source/pico-examples1/build/usb/device/tinyusb_device_examples/audio_4_channel_mic && python -j /home/peterh/source/pico-examples1/build/usb/device/tinyusb_device_examples/audio_4_channel_mic/audio_4_channel_mic.elf.map Unknown option: -j usage: python [option] ... [-c cmd | -m mod | file | -] [arg] ... Try `python -h' for more information. make[2]: *** [usb/device/tinyusb_device_examples/audio_4_channel_mic/CMakeFiles/audio_4_channel_mic.dir/build.make:1509: usb/device/tinyusb_device_examples/audio_4_channel_mic/audio_4_channel_mic.elf] Error 2 ``` Not sure why I didn't see this before. It's something to do with family_add_linkermap, LINKERMAP_PY is empty ``` CMake Error at /home/peterh/source/pico-sdk1/lib/tinyusb/hw/bsp/family_support.cmake:264 (message): why isn't LINKERMAP_PY defined? Call Stack (most recent call first): /home/peterh/source/pico-sdk1/lib/tinyusb/hw/bsp/family_support.cmake:527 (family_add_linkermap) /home/peterh/source/pico-sdk1/lib/tinyusb/hw/bsp/rp2040/family.cmake:248 (family_configure_common) /home/peterh/source/pico-sdk1/lib/tinyusb/hw/bsp/rp2040/family.cmake:261 (family_configure_example) /home/peterh/source/pico-sdk1/lib/tinyusb/examples/device/audio_4_channel_mic/CMakeLists.txt:35 (family_configure_device_example) ``` For some reason - my fix work ok https://github.com/raspberrypi/pico-examples/pull/778 later: The develop version of pico-examples resets LINKERMAP_PY which goes out of scope - but your PR removes this https://github.com/raspberrypi/pico-examples/pull/787. So I think that's a different issue and this pico-sdk PR is ok.
peterharperuk (Migrated from github.com) reviewed 2026-09-02 05:38:16 -05:00
kilograham (Migrated from github.com) reviewed 2026-09-02 13:52:50 -05:00
kilograham (Migrated from github.com) commented 2026-09-02 13:52:50 -05:00

warning seems fine on latest

warning seems fine on latest
kilograham commented 2026-09-02 13:53:13 -05:00 (Migrated from github.com)

note i backed out the change for linkermap here, and moved it back to pico-examples

note i backed out the change for linkermap here, and moved it back to pico-examples
Sign in to join this conversation.
No reviewers
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-raspberrypi/pico-sdk!3163
No description provided.