Set execute bit on scripts with shebangs #3197

Open

ypsvlq wants to merge 2 commits from ypsvlq/execute-bit into develop

ypsvlq commented

2026-09-16 05:41:04 -05:00

(Migrated from github.com)

Fixes #3196.

lurch commented

2026-09-16 06:15:16 -05:00

(Migrated from github.com)

Nice catch. However it looks like tools/bazel_common.py should probably have the shebang line removed, because it only consists of functions (which are presumably called from other scripts) and doesn't have any "executable" section of it's own?

EDIT: Yep 🙂

$ git grep bazel_common
tools/bazel_build.py:from bazel_common import (
tools/bazel_buildifier_lint_check.py:from bazel_common import (
tools/check_source_files_in_bazel_build.py:from bazel_common import (
tools/compare_build_systems.py:from bazel_common import SDK_ROOT, setup_logging
tools/run_all_bazel_checks.py:from bazel_common import (

Nice catch. However it looks like `tools/bazel_common.py` should probably have the shebang line removed, because it only consists of functions (which are presumably called from other scripts) and doesn't have any "executable" section of it's own? EDIT: Yep :slightly_smiling_face: ``` $ git grep bazel_common tools/bazel_build.py:from bazel_common import ( tools/bazel_buildifier_lint_check.py:from bazel_common import ( tools/check_source_files_in_bazel_build.py:from bazel_common import ( tools/compare_build_systems.py:from bazel_common import SDK_ROOT, setup_logging tools/run_all_bazel_checks.py:from bazel_common import ( ```

👍 1

lurch (Migrated from github.com) approved these changes

2026-09-16 06:42:59 -05:00

This pull request can be merged automatically.

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin 'ypsvlq/execute-bit:ypsvlq/execute-bit'

git switch 'ypsvlq/execute-bit'

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch 'develop'

git merge --no-ff 'ypsvlq/execute-bit'

git switch 'ypsvlq/execute-bit'

git rebase 'develop'

git switch 'develop'

git merge --ff-only 'ypsvlq/execute-bit'

git switch 'ypsvlq/execute-bit'

git rebase 'develop'

git switch 'develop'

git merge --no-ff 'ypsvlq/execute-bit'

git switch 'develop'

git merge --squash 'ypsvlq/execute-bit'