Add missing cast to uint32_t in hw_divider_u32_quotient for host #436

2021-05-23T08:15:08-05:00

jonathangjertsen commented

2021-05-23 08:15:08 -05:00

(Migrated from github.com)

Fixes the following warning:

[...]/pico-sdk/src/host/hardware_divider/include/hardware/divider.h:81:26: warning: operand of ?: changes signedness from 'int' to 'uint32_t' {aka 'unsigned int'} due to unsignedness of other operand [-Wsign-compare]
     return b ? (a / b) : -1;
                          ^~

The fix is to make the cast explicit, like hw_divider_divmod_u32 already does

Fixes the following warning: ``` [...]/pico-sdk/src/host/hardware_divider/include/hardware/divider.h:81:26: warning: operand of ?: changes signedness from 'int' to 'uint32_t' {aka 'unsigned int'} due to unsignedness of other operand [-Wsign-compare] return b ? (a / b) : -1; ^~ ``` The fix is to make the cast explicit, like `hw_divider_divmod_u32` already does

 @ -80,3 +80,3 @@
 static inline uint32_t hw_divider_u32_quotient(uint32_t a, uint32_t b) {
     return b ? (a / b) : -1;
     return b ? (a / b) : (uint32_t)(-1);
 }

Rows
Columns