Add missing board detection macros #448

Merged

2bndy5 merged 4 commits from add-sparkfun-board-detection into develop

2021-05-27 11:55:38 -05:00

2bndy5 commented

2021-05-25 20:57:52 -05:00

(Migrated from github.com)

@kirk-sfe this PR addresses my subsequent concern as mentioned in https://github.com/raspberrypi/pico-sdk/issues/328#issuecomment-845622997

I'm open to using a different nomenclature... I just went with #define <board-producer>_<board-variant>

This adds macros to some of the boards' header files for detecting what board is targeted. This affects all Sparkfun boards and the RPi Pico & VGA board (for good measure). This doesn't really satisfy any particular issue, rather it keeps a uniform layout in the header files (all Pimoroni, Adafruit, and Arduino board headers already have this board detection macro). @kirk-sfe this PR addresses my subsequent concern as mentioned in https://github.com/raspberrypi/pico-sdk/issues/328#issuecomment-845622997 I'm open to using a different nomenclature... I just went with `#define <board-producer>_<board-variant>`

lurch (Migrated from github.com) approved these changes

2021-05-26 05:49:58 -05:00

lurch (Migrated from github.com) left a comment

LGTM

kilograham (Migrated from github.com) approved these changes

2021-05-26 07:17:54 -05:00

2bndy5 commented

2021-05-26 15:27:20 -05:00

(Migrated from github.com)

Still unclear about contributing guidelines here. I see that I have the option to squash and merge myself, but shouldn't that be decided by the maintainers (not contributors)?

EDIT: Looks like I was misled by the Github mobile app (where the merge options are displayed for me). The merge options rightfully don't display for me on the PC browser. This might be something to mention when addressing #346

Still unclear about contributing guidelines here. I see that I have the option to squash and merge myself, but shouldn't that be decided by the maintainers (not contributors)? EDIT: Looks like I was misled by the Github mobile app (where the merge options are displayed for me). The merge options rightfully don't display for me on the PC browser. This might be something to mention when addressing #346

😆 1

ghost commented

2021-05-27 10:59:47 -05:00

(Migrated from github.com)