Added some waveshare boards definition #619

2021-10-17T22:46:05-05:00

EngineerWill commented

2021-10-17 22:46:05 -05:00

(Migrated from github.com)

Added some waveshare boards definition
RP2040-LCD-0.96
The other boards are not on the shop yet, but I've got them.

This is my first time to pull request. I may have made a mistake in several operations. Please forgive me

Added some waveshare boards definition RP2040-LCD-0.96 The other boards are not on the shop yet, but I've got them. This is my first time to pull request. I may have made a mistake in several operations. Please forgive me

lurch (Migrated from github.com) reviewed

2021-10-21 12:47:27 -05:00

src/boards/include/boards/waveshare_rp2040_lcd_0.96.h

					
				@ -0,0 +1,104 @@

				/*

@kilograham As I mentioned in one of the previous iterations of this PR, I dunno if we ought to be allowing this to introduce a PICO_LCD_SPI define (which IMHO feels a bit generic), or requesting that it instead uses a more board-specific name e.g. WAVESHARE_RP2040_LCD_SPI ?

@kilograham As I mentioned in one of the previous iterations of this PR, I dunno if we ought to be allowing this to introduce a `PICO_LCD_SPI` define (which IMHO feels a bit generic), or requesting that it instead uses a more board-specific name e.g. `WAVESHARE_RP2040_LCD_SPI` ?

lurch commented

2021-10-21 12:48:54 -05:00

(Migrated from github.com)

One comment, but otherwise LGTM.

EngineerWill (Migrated from github.com) reviewed

2021-10-25 02:39:35 -05:00

src/boards/include/boards/waveshare_rp2040_lcd_0.96.h

					
				@ -0,0 +1,104 @@

				/*

I think it's a good idea. I'll change some macro names.
Do I need to click the Resolve button?

I think it's a good idea. I'll change some macro names. Do I need to click the Resolve button?

lurch (Migrated from github.com) reviewed

2021-10-25 04:01:35 -05:00

src/boards/include/boards/waveshare_rp2040_lcd_0.96.h

					
				@ -0,0 +1,104 @@

				/*

Thanks @EngineerWill 👍

Thanks @EngineerWill :+1:

lurch (Migrated from github.com) reviewed

2021-10-25 04:03:27 -05:00

kilograham commented

2021-10-25 08:59:26 -05:00

(Migrated from github.com)

do any of these boards have RP2040-B1 chips on them? if not probably best to have PICO_FLOAT_SUPPORT_ROM_V1 and friends be 0. It is not critical though, so I will merge without it for now if I don't hear back before 1.3.0 release which is imminent

kilograham commented

2021-10-25 09:30:53 -05:00

(Migrated from github.com)

Note, that you should now just set use PICO_RP2040_B0_SUPPORTED = 0 instead of the two old flags

EngineerWill commented

2021-10-25 21:19:02 -05:00

(Migrated from github.com)

do any of these boards have RP2040-B1 chips on them? if not probably best to have PICO_FLOAT_SUPPORT_ROM_V1 and friends be 0. It is not critical though, so I will merge without it for now if I don't hear back before 1.3.0 release which is imminent

hi kilograham .There is no problem. I have submitted it. Please check whether it is right

> do any of these boards have RP2040-B1 chips on them? if not probably best to have PICO_FLOAT_SUPPORT_ROM_V1 and friends be 0. It is not critical though, so I will merge without it for now if I don't hear back before 1.3.0 release which is imminent hi kilograham .There is no problem. I have submitted it. Please check whether it is right

kilograham (Migrated from github.com) approved these changes

2021-10-26 13:46:03 -05:00

Sign in to join this conversation.

No reviewers

kilograham