Add __wrap_ prefix to remquo and remquof calls #723

Open

KarlK90 wants to merge 1 commit from KarlK90/fix/wrap_remquo_remquof_math into develop

KarlK90 commented

2022-02-04 16:15:19 -06:00

(Migrated from github.com)

Linking with LTO enabled would otherwise result in an error with undefined reference to __wrap_remquof' possibly because they are in the same translation unit. Compiling without LTO worked but I'm not which function remquof was resolved.

Linking with LTO enabled would otherwise result in an error with `undefined reference to __wrap_remquof'` possibly because they are in the same translation unit. Compiling without LTO worked but I'm not which function `remquof` was resolved.

This pull request has changes conflicting with the target branch.

src/rp2_common/pico_double/double_math.c
src/rp2_common/pico_float/float_math.c

View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Merge commit title

Merge pull request 'Add __wrap_ prefix to remquo and remquof calls' (#723) from KarlK90/fix/wrap_remquo_remquof_math into develop

Merge commit body

Reviewed-on: https://git.richey.dev/gh-raspberrypi/pico-sdk/pulls/723

Merge pull request 'Add __wrap_ prefix to remquo and remquof calls' (#723) from KarlK90/fix/wrap_remquo_remquof_math into develop

Reviewed-on: https://git.richey.dev/gh-raspberrypi/pico-sdk/pulls/723

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin 'KarlK90/fix/wrap_remquo_remquof_math:KarlK90/fix/wrap_remquo_remquof_math'

git switch 'KarlK90/fix/wrap_remquo_remquof_math'

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch 'develop'

git merge --no-ff 'KarlK90/fix/wrap_remquo_remquof_math'

git switch 'KarlK90/fix/wrap_remquo_remquof_math'

git rebase 'develop'

git switch 'develop'

git merge --ff-only 'KarlK90/fix/wrap_remquo_remquof_math'

git switch 'KarlK90/fix/wrap_remquo_remquof_math'

git rebase 'develop'

git switch 'develop'

git merge --no-ff 'KarlK90/fix/wrap_remquo_remquof_math'

git switch 'develop'

git merge --squash 'KarlK90/fix/wrap_remquo_remquof_math'