gh-raspberrypi/pico-sdk
Watch
1
0
Fork
You've already forked pico-sdk
 0
Code Issues 262 Pull requests 63 Releases Activity

Add board definition for the RP2040 Stamp Round Carrier #837

Merged
arturo182 merged 4 commits from round_carrier_board into develop 2022-06-17 12:58:13 -05:00
Conversation 10 Commits 4 Files changed 1 +79
arturo182 commented 2022-05-22 06:59:21 -05:00 (Migrated from github.com)

The file modifies a few pins and then includes the stamp board file.

Details about the board available here: https://www.solder.party/docs/rp2040-stamp/round-carrier/

The file modifies a few pins and then includes the stamp board file. Details about the board available here: https://www.solder.party/docs/rp2040-stamp/round-carrier/
lurch (Migrated from github.com) reviewed 2022-05-23 07:19:11 -05:00
src/boards/include/boards/solderparty_rp2040_stamp_round_carrier.h
@ -0,0 +38,4 @@
// --- Neopixel Ring ---
#ifndef PICO_DEFAULT_WS2812_PIN
#define PICO_DEFAULT_WS2812_PIN 24
lurch (Migrated from github.com) commented 2022-05-23 07:19:11 -05:00

Looking at the product-page you mentioned, I guess the on-board NeoPixel doesn't stop working when the Stamp is on the Carrier Board, so perhaps the Carrier Board NeoPixel pin should get its own #define, rather than overriding the PICO_DEFAULT_WS2812_PIN from solderparty_rp2040_stamp.h? 🤷

Looking at the product-page you mentioned, I guess the on-board NeoPixel doesn't stop working when the Stamp is on the Carrier Board, so perhaps the Carrier Board NeoPixel pin should get its own `#define`, rather than overriding the `PICO_DEFAULT_WS2812_PIN` from `solderparty_rp2040_stamp.h`? :shrug:
lurch (Migrated from github.com) reviewed 2022-05-23 07:21:53 -05:00
src/boards/include/boards/solderparty_rp2040_stamp_round_carrier.h
@ -0,0 +34,4 @@
#endif
#ifndef PICO_DEFAULT_UART_RX_PIN
#define PICO_DEFAULT_UART_RX_PIN 17
#endif
lurch (Migrated from github.com) commented 2022-05-23 07:21:53 -05:00

Given that this is redefining all the UART pins, perhaps it's worth specifying the PICO_DEFAULT_UART definition, just to be on the safe side?

Given that this is redefining all the UART pins, perhaps it's worth specifying the `PICO_DEFAULT_UART` definition, just to be on the safe side?
lurch (Migrated from github.com) reviewed 2022-05-23 07:22:28 -05:00
src/boards/include/boards/solderparty_rp2040_stamp_round_carrier.h
@ -0,0 +55,4 @@
#endif
#ifndef PICO_DEFAULT_I2C_SCL_PIN
#define PICO_DEFAULT_I2C_SCL_PIN 1
#endif
lurch (Migrated from github.com) commented 2022-05-23 07:22:27 -05:00

Given that this is redefining all the I2C pins, perhaps it's worth specifying the PICO_DEFAULT_I2C definition, just to be on the safe side?

Given that this is redefining all the I2C pins, perhaps it's worth specifying the `PICO_DEFAULT_I2C` definition, just to be on the safe side?
arturo182 (Migrated from github.com) reviewed 2022-05-23 09:10:56 -05:00
src/boards/include/boards/solderparty_rp2040_stamp_round_carrier.h
@ -0,0 +38,4 @@
// --- Neopixel Ring ---
#ifndef PICO_DEFAULT_WS2812_PIN
#define PICO_DEFAULT_WS2812_PIN 24
arturo182 (Migrated from github.com) commented 2022-05-23 09:10:55 -05:00

I thought about it, but I think I'd rather have the Carrier NeoPixel ring take priority over the single NeoPixel on the Stamp 😅

I thought about it, but I think I'd rather have the Carrier NeoPixel ring take priority over the single NeoPixel on the Stamp 😅
arturo182 (Migrated from github.com) reviewed 2022-05-23 09:11:07 -05:00
src/boards/include/boards/solderparty_rp2040_stamp_round_carrier.h
@ -0,0 +34,4 @@
#endif
#ifndef PICO_DEFAULT_UART_RX_PIN
#define PICO_DEFAULT_UART_RX_PIN 17
#endif
arturo182 (Migrated from github.com) commented 2022-05-23 09:11:07 -05:00

Sure, will do :)

Sure, will do :)
lurch (Migrated from github.com) reviewed 2022-05-23 09:23:10 -05:00
src/boards/include/boards/solderparty_rp2040_stamp_round_carrier.h
@ -0,0 +38,4 @@
// --- Neopixel Ring ---
#ifndef PICO_DEFAULT_WS2812_PIN
#define PICO_DEFAULT_WS2812_PIN 24
lurch (Migrated from github.com) commented 2022-05-23 09:23:10 -05:00

Okay, so perhaps you want to add an additional define to the carrier's header-file with the definition of the stamp's neopixel pin, so that code written to target the carrier can write to both (defined) neopixel pins? 🙂

Okay, so perhaps you want to add an additional define to the carrier's header-file with the definition of the stamp's neopixel pin, so that code written to target the carrier can write to both (defined) neopixel pins? :slightly_smiling_face:
lurch (Migrated from github.com) reviewed 2022-05-23 12:50:01 -05:00
src/boards/include/boards/solderparty_rp2040_stamp_round_carrier.h
@ -0,0 +33,4 @@
#define PICO_DEFAULT_UART_TX_PIN 16
#endif
#ifndef PICO_DEFAULT_UART_RX_PIN
#define PICO_DEFAULT_UART_RX_PIN 17
lurch (Migrated from github.com) commented 2022-05-23 12:50:01 -05:00

This should probably be something like SOLDERPARTY_RP2040_STAMP_... rather than PICO_STAMP_..., as it's a feature specific to this board and not to any other Pico boards.

This should probably be something like `SOLDERPARTY_RP2040_STAMP_...` rather than `PICO_STAMP_...`, as it's a feature specific to this board and not to any other Pico boards.
arturo182 (Migrated from github.com) reviewed 2022-05-23 15:10:53 -05:00
src/boards/include/boards/solderparty_rp2040_stamp_round_carrier.h
@ -0,0 +33,4 @@
#define PICO_DEFAULT_UART_TX_PIN 16
#endif
#ifndef PICO_DEFAULT_UART_RX_PIN
#define PICO_DEFAULT_UART_RX_PIN 17
arturo182 (Migrated from github.com) commented 2022-05-23 15:10:53 -05:00

Gotcha 👍

Gotcha 👍
lurch (Migrated from github.com) approved these changes 2022-05-23 17:24:32 -05:00
lurch (Migrated from github.com) left a comment

LGTM! And hopefully @kilograham agrees with all my suggestions 😉

LGTM! And hopefully @kilograham agrees with all my suggestions :wink:
kilograham (Migrated from github.com) approved these changes 2022-06-17 12:58:05 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
lurch
kilograham
Labels
Clear labels   
bazel

   
bluetooth

   
board settings

   
boot_stage2

   
bug
Something isn't working

  
build

   
c++

   
can't reproduce
Can not reproduce the bug

  
clang

   
clib-interface

   
cmsis

   
code cleanliness

   
code size

   
compiler version issues

   
cyw43_driver

   
debug

   
discussion

   
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
dynamic_clock

   
elf2uf2

   
enhancement
New feature or request

  
errata

   
filesystem

   
flash layout

   
floating point

   
FreeRTOS

   
hardware_adc

   
hardware_claim

   
hardware_clocks

   
hardware_dma

   
hardware_exception

   
hardware_flash

   
hardware_gpio

   
hardware_i2c

   
hardware_irq

   
hardware_pio

   
hardware_pwm

   
hardware_rcp

   
hardware_rtc

   
hardware_spi

   
hardware_sync

   
hardware_uart

   
hardware_vreg

   
hardware_watchdog

   
hardware_xosc

   
help wanted
Extra attention is needed

  
host

   
IAR

   
installation

   
invalid
This doesn't seem right

  
linker scripts

   
lto

   
lwip

   
mbedtls

   
missing API

   
needs reporter detail

   
networking

   
newlib

   
newlib-multicore

   
non-c

   
non-cmake

   
non-gcc

   
openocd

   
orphan PR

   
OS integration

   
pico_async_context

   
pico_base

   
pico_binary_info

   
pico_flash

   
picolibc

   
pico_lwip

   
pico_malloc

   
pico_multicore

   
pico_printf

   
pico_runtime

   
pico_stdio

   
pico_stdio_usb

   
pico_sync

   
pico_time

   
pico_util

   
pioasm

   
port
issues or discussions of porting code/libraries to rp2040

  
question
Further information is requested

  
review

   
review2

   
rtos interop
Consideration for FreeRTOS co-existence

  
runtime init

   
static library

   
svd

   
test

   
tinyusb

   
vscode

   
wifi integration

   
wontfix
This will not be worked on

No labels
bazel
bluetooth
board settings
boot_stage2
bug
build
c++
can't reproduce
clang
clib-interface
cmsis
code cleanliness
code size
compiler version issues
cyw43_driver
debug
discussion
documentation
duplicate
dynamic_clock
elf2uf2
enhancement
errata
filesystem
flash layout
floating point
FreeRTOS
hardware_adc
hardware_claim
hardware_clocks
hardware_dma
hardware_exception
hardware_flash
hardware_gpio
hardware_i2c
hardware_irq
hardware_pio
hardware_pwm
hardware_rcp
hardware_rtc
hardware_spi
hardware_sync
hardware_uart
hardware_vreg
hardware_watchdog
hardware_xosc
help wanted
host
IAR
installation
invalid
linker scripts
lto
lwip
mbedtls
missing API
needs reporter detail
networking
newlib
newlib-multicore
non-c
non-cmake
non-gcc
openocd
orphan PR
OS integration
pico_async_context
pico_base
pico_binary_info
pico_flash
picolibc
pico_lwip
pico_malloc
pico_multicore
pico_printf
pico_runtime
pico_stdio
pico_stdio_usb
pico_sync
pico_time
pico_util
pioasm
port
question
review
review2
rtos interop
runtime init
static library
svd
test
tinyusb
vscode
wifi integration
wontfix
Milestone
Clear milestone
No items
No milestone
1.4.0
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-raspberrypi/pico-sdk!837
No description provided.