Add conversion to/from io::Error for kv::Error #336

Merged
tmccombs merged 2 commits from kv-error into master 2019-07-03 16:51:15 -05:00
tmccombs commented 2019-07-01 12:33:50 -05:00 (Migrated from github.com)

And keep the original error, so that an io error inside the visitor is
returned accessible by the call to visit.

I started working on adding kv support to envlogger, and found that with the current implementation of kv::Error, it isn't possible to keep information about io errors from inside the visitor.

And keep the original error, so that an io error inside the visitor is returned accessible by the call to `visit`. I started working on adding kv support to envlogger, and found that with the current implementation of kv::Error, it isn't possible to keep information about io errors from inside the visitor.
KodrAus (Migrated from github.com) approved these changes 2019-07-03 16:51:02 -05:00
KodrAus (Migrated from github.com) left a comment

Thanks @tmccombs!

This looks good to me.

Thanks @tmccombs! This looks good to me.
Sign in to join this conversation.
No reviewers
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-rust-lang/log!336
No description provided.