Split MSRV used to build from MSRV used to test #741
No reviewers
Labels
No labels
bug
duplicate
easy
enhancement
help wanted
invalid
question
rfc
structured-logging
wontfix
No milestone
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
gh-rust-lang/log!741
Loading…
Reference in a new issue
No description provided.
Delete branch "ci/msrv-build-vs-test"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes #740
Our dev dependencies require a higher MSRV than
logitself actually needs. This PR splits our MSRV check between what's needed to depend onlogand what's needed to buildlogitself. I split them rather than just removing the tests from MSRV altogether because I think that's still worth tracking.I've also removed 32bit Windows from CI since it seems like it's losing support. Apologies to anyone trying to build
logfor Windows ME 🙏@ -126,0 +123,4 @@- run: cargo run --verbose --manifest-path test_max_level_features/Cargo.toml- run: cargo run --verbose --manifest-path test_max_level_features/Cargo.toml --releasemsrv-test:Nit: the job short name is check, the display name is build and we're actually running of the test, probably want to make that consistent.
View changes since the review
I don't think we need Clippy here? Same for the msrv-check job.
View changes since the review
@ -126,0 +123,4 @@- run: cargo run --verbose --manifest-path test_max_level_features/Cargo.toml- run: cargo run --verbose --manifest-path test_max_level_features/Cargo.toml --releasemsrv-test:Fair 👍 I’ll clean these up
Pull request closed