Update SQL request #4

Merged

jeckyl merged 2 commits from patch-1 into master 2020-11-05 07:44:50 -06:00

Conversation 4 Commits 2 Files changed 1 +1 -1

jeckyl commented 2020-11-03 09:52:54 -06:00 (Migrated from github.com)

• Copy link
• Copy Markdown

The modification makes it possible to properly take into account the value 0 in the option of the number of days defining new products and avoid displaying the new label.

The modification makes it possible to properly take into account the value 0 in the option of the number of days defining new products and avoid displaying the new label.

getdatakick commented 2020-11-05 07:22:47 -06:00 (Migrated from github.com)

• Copy link
• Copy Markdown

Thank you for the PR. Could you please remove updating module version from the code?

$this->version = '2.2.2'

Version is updated when new version is released

Thank you for the PR. Could you please remove updating module version from the code? ``` $this->version = '2.2.2' ``` Version is updated when new version is released

getdatakick (Migrated from github.com) requested changes 2020-11-05 07:23:21 -06:00

blockbestsellers.php

getdatakick (Migrated from github.com) commented 2020-11-05 07:23:14 -06:00

• Copy link
• Copy Markdown

Please don't change version

Please don't change version

jeckyl (Migrated from github.com) reviewed 2020-11-05 07:25:34 -06:00

blockbestsellers.php

jeckyl (Migrated from github.com) commented 2020-11-05 07:25:34 -06:00

• Copy link
• Copy Markdown

corrected

corrected

getdatakick commented 2020-11-05 07:45:01 -06:00 (Migrated from github.com)

• Copy link
• Copy Markdown

Thank you very much

Thank you very much

Sign in to join this conversation.

Reviewers

No reviewers

getdatakick

Labels

Clear labels   

bug

  

duplicate

  

enhancement

  

help wanted

  

invalid

  

question

  

wontfix

No labels

bug

duplicate

enhancement

help wanted

invalid

question

wontfix

Milestone

Clear milestone

No items

No milestone

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

gh-thirtybees/blockbestsellers!4

No description provided.