Organize folders #3

Closed
mauroagr wants to merge 2 commits from organize_folders into master
mauroagr commented 2018-08-23 22:55:24 -05:00 (Migrated from github.com)

Put the files in the correct folders structure to be more easy to update

Put the files in the correct folders structure to be more easy to update
Traumflug commented 2018-08-24 05:32:59 -05:00 (Migrated from github.com)

First, thanks for the contribution. Cleaning code is always a good idea.

Regarding the second commit, there's validatemodule.sh to find out whether the change is good. One runs it like this:

cd modules/blocksearch
../../tools/validatemodules.sh

This script also supports a number of parameters, run it with -h to get a description.

Regarding the first commit, there should be no need for such code changes. There are "magic" places where templates, JS and CSS get found by just their name. However, I'm not aware of documentation other than the code. The secret lies somewhere between lines 3075 and 3200 in classes/module/Module.php for templates. And somewhere in Media.php and/or Controller.php for JS and CSS.

First, thanks for the contribution. Cleaning code is always a good idea. Regarding the second commit, there's `validatemodule.sh` to find out whether the change is good. One runs it like this: ```sh cd modules/blocksearch ../../tools/validatemodules.sh ``` This script also supports a number of parameters, run it with `-h` to get a description. Regarding the first commit, there should be no need for such code changes. There are "magic" places where templates, JS and CSS get found by just their name. However, I'm not aware of documentation other than the code. The secret lies somewhere between lines 3075 and 3200 in `classes/module/Module.php` for templates. And somewhere in `Media.php` and/or `Controller.php` for JS and CSS.
mauroagr commented 2018-08-24 15:11:07 -05:00 (Migrated from github.com)

I run the validation, have much things to change, in next days i will update it.

I run the validation, have much things to change, in next days i will update it.

Pull request closed

Sign in to join this conversation.
No reviewers
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-thirtybees/blocksearch!3
No description provided.