gh-thirtybees/community-theme-default
Watch
1
0
Fork
You've already forked community-theme-default
 0
Code Issues 2 Pull requests 4 Releases Activity

Dropdown Cart on mobile fix #93

Open
deweblooper wants to merge 1 commit from deweblooper/dropdown-cart-on-mobile-fix into 1.1.x
pull from: deweblooper/dropdown-cart-on-mobile-fix
merge into: gh-thirtybees:1.1.x
Conversation 0 Commits 1 Files changed 1 +45 -36
deweblooper commented 2022-09-14 12:58:42 -05:00 (Migrated from github.com)

On Chrome, when some product is added to cart, in both Thirtybees themes - "Niara" and "Comunity Theme Default", dropdown cart make on first tap strange move of sliding up instead of sliding down, on mobile Chrome or browser Chrome in DevTools mobile mode with touch enabled.
It happens just on very first tap on cart icon placed right top in header on each of eshop pages. Then it works correctly until page reload.
After reload again, first tap on cart icon and dropdown cart hidden trigger not dropdown slide-down but slide-up, then again OK.
On Firefox and Safari this anomaly was not present, just Chrome (mobile).

Notice: this is very old behavior, it happens on Prestshops 1.6.x original theme too, and it was brought to Thirtybees then.

On Chrome, when some product is added to cart, in both Thirtybees themes - "Niara" and "Comunity Theme Default", dropdown cart make on first tap strange move of sliding up instead of sliding down, on mobile Chrome or browser Chrome in DevTools mobile mode with touch enabled. It happens just on very first tap on cart icon placed right top in header on each of eshop pages. Then it works correctly until page reload. After reload again, first tap on cart icon and dropdown cart hidden trigger not dropdown slide-down but slide-up, then again OK. On Firefox and Safari this anomaly was not present, just Chrome (mobile). Notice: this is very old behavior, it happens on Prestshops 1.6.x original theme too, and it was brought to Thirtybees then.
This pull request is broken due to missing fork information.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin 'deweblooper/dropdown-cart-on-mobile-fix:deweblooper/dropdown-cart-on-mobile-fix'
git switch 'deweblooper/dropdown-cart-on-mobile-fix'

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch '1.1.x'
git merge --no-ff 'deweblooper/dropdown-cart-on-mobile-fix'
git switch 'deweblooper/dropdown-cart-on-mobile-fix'
git rebase '1.1.x'
git switch '1.1.x'
git merge --ff-only 'deweblooper/dropdown-cart-on-mobile-fix'
git switch 'deweblooper/dropdown-cart-on-mobile-fix'
git rebase '1.1.x'
git switch '1.1.x'
git merge --no-ff 'deweblooper/dropdown-cart-on-mobile-fix'
git switch '1.1.x'
git merge --squash 'deweblooper/dropdown-cart-on-mobile-fix'
git switch '1.1.x'
git merge --ff-only 'deweblooper/dropdown-cart-on-mobile-fix'
git switch '1.1.x'
git merge 'deweblooper/dropdown-cart-on-mobile-fix'
git push origin '1.1.x'
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
help wanted

   
invalid

   
question

   
wontfix
No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-thirtybees/community-theme-default!93
No description provided.