gh-thirtybees/socialsharing
Watch
1
0
Fork
You've already forked socialsharing
 0
Code Issues Pull requests Releases Activity

Enhances Social Sharing Module by sending GA social interaction data #2

Merged
inetbiz merged 3 commits from patch-1 into dev 2017-04-23 06:57:18 -05:00
Conversation 6 Commits 3 Files changed 1 +6
inetbiz commented 2017-04-21 11:29:51 -05:00 (Migrated from github.com)

This begins work on issue #1 to add GA social interactions .onclick.

This begins work on issue #1 to add GA social interactions .onclick.
inetbiz commented 2017-04-21 11:30:36 -05:00 (Migrated from github.com)

@firstred would you review the JS for me? I'm still testing GA results on a client site with these changes.

@firstred would you review the JS for me? I'm still testing GA results on a client site with these changes.
inetbiz (Migrated from github.com) reviewed 2017-04-21 11:48:58 -05:00
js/socialsharing.js
@ -32,12 +32,17 @@ $(document).ready(function(){
{
inetbiz (Migrated from github.com) commented 2017-04-21 11:48:58 -05:00

sharing_url did not populate when sent to ga()

`sharing_url` did not populate when sent to `ga()`
inetbiz commented 2017-04-21 12:17:25 -05:00 (Migrated from github.com)

I updated it to send the name of the entity, sharing_name because you can use secondary dimensions in your GA report to show the URL shared. This PR is ready for merging, @firstred

I updated it to send the name of the entity, `sharing_name` because you can use secondary dimensions in your GA report to show the URL shared. This PR is ready for merging, @firstred
inetbiz commented 2017-04-21 12:25:37 -05:00 (Migrated from github.com)

2017-04-21_13-19-47

![2017-04-21_13-19-47](https://cloud.githubusercontent.com/assets/3696477/25289035/004aa84e-2696-11e7-9180-1c0495826f1a.jpg)
eschiendorfer (Migrated from github.com) reviewed 2017-04-21 21:09:13 -05:00
js/socialsharing.js
@ -32,12 +32,17 @@ $(document).ready(function(){
{
eschiendorfer (Migrated from github.com) commented 2017-04-21 21:09:13 -05:00

Shouldn't it be "sharing_name"?

Shouldn't it be "sharing_name"?
firstred commented 2017-04-23 06:57:11 -05:00 (Migrated from github.com)

This PR is ready for merging

It is!
What a great contribution, Denver! Some real good work.

> This PR is ready for merging It is! What a great contribution, Denver! Some real good work.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
help wanted

   
invalid

   
question

   
wontfix
No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-thirtybees/socialsharing!2
No description provided.