Avoid unnecessary DB query on users' password check. #13

Closed

gonssal wants to merge 1 commit from avoid-unnecessary-db-query-on-users-password-check into master

gonssal commented

2018-09-17 22:25:05 -05:00

(Migrated from github.com)

Same as https://github.com/thirtybees/thirtybees/pull/599

I feel it should also have the guard from core:

if (!$result) {
    return false;
}

But I didn't add it in case it breaks something.

Same as https://github.com/thirtybees/thirtybees/pull/599 I feel it should also have the guard from core: ```php if (!$result) { return false; } ``` But I didn't add it in case it breaks something.

Traumflug commented

2018-09-19 05:56:31 -05:00

(Migrated from github.com)

Thanks a lot for this contribution.

While it's a valid contribution with a worthwhile goal, I'm not going to pick this, because
a) This part of tbupdater is likely unused. Most of the classes there were copied 1:1 from core in an attempt to make this module independent from core. Whether this goal is achieved is unknown.
b) Module tbupdater is pretty much abandoned.
c) Breaking tbupdater would be a nightmare.

Thanks a lot for this contribution. While it's a valid contribution with a worthwhile goal, I'm not going to pick this, because a) This part of *tbupdater* is likely unused. Most of the classes there were copied 1:1 from core in an attempt to make this module independent from core. Whether this goal is achieved is unknown. b) Module *tbupdater* is pretty much abandoned. c) Breaking *tbupdater* would be a nightmare.

Traumflug commented

2019-05-04 17:43:43 -05:00

(Migrated from github.com)