Fix support for PHP 7.2 #14

Closed
gonssal wants to merge 1 commit from fix-archive-tar-php-72 into master
gonssal commented 2018-09-19 14:24:24 -05:00 (Migrated from github.com)

Just updated the library (https://pear.php.net/package/Archive_Tar/) to the latest version to support PHP 7.2. This is handled by Composer in core.

Also changed the PEAR class_exists conditional because it had a typo (should have been PsOneSixMigrator and not Sig) and it would never trigger. Even if the typo was fixed, it would lead to an error because the class would be namespaced then. So I just reverted it to the original code.

Just updated the library (https://pear.php.net/package/Archive_Tar/) to the latest version to support PHP 7.2. This is handled by Composer in core. Also changed the PEAR `class_exists` conditional because it had a typo (should have been `PsOneSixMigrator` and not `Sig`) and it would never trigger. Even if the typo was fixed, it would lead to an error because the class would be namespaced then. So I just reverted it to the original code.
Traumflug commented 2019-05-04 17:57:25 -05:00 (Migrated from github.com)

Looks like you know what you're doing. Picked to master. Thank you very much for the contribution!

Looks like you know what you're doing. Picked to _master_. Thank you very much for the contribution!

Pull request closed

Sign in to join this conversation.
No reviewers
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-thirtybees/tbupdater!14
No description provided.