Fix support for PHP 7.2 #14
No reviewers
Labels
No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
No milestone
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
gh-thirtybees/tbupdater!14
Loading…
Reference in a new issue
No description provided.
Delete branch "fix-archive-tar-php-72"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Just updated the library (https://pear.php.net/package/Archive_Tar/) to the latest version to support PHP 7.2. This is handled by Composer in core.
Also changed the PEAR
class_existsconditional because it had a typo (should have beenPsOneSixMigratorand notSig) and it would never trigger. Even if the typo was fixed, it would lead to an error because the class would be namespaced then. So I just reverted it to the original code.Looks like you know what you're doing. Picked to master. Thank you very much for the contribution!
Pull request closed