Use copy_from_slice instead of copy_memory #173

New issue

Closed

opened 2018-03-18 06:23:43 -05:00 by nox · 4 comments

nox commented

2018-03-18 06:23:43 -05:00

(Migrated from github.com)

There is no need to write our own copy_memory method, we can just use <[_]>::copy_from_slice which can be implemented in a more optimised way by the standard library.

There is no need to write our own `copy_memory` method, we can just use [`<[_]>::copy_from_slice`](https://doc.rust-lang.org/std/primitive.slice.html#method.copy_from_slice) which can be implemented in a more optimised way by the standard library.

kinggoesgaming commented

2018-03-18 17:46:39 -05:00

(Migrated from github.com)

So testing it, it seems our copy_memory function is faster than builtin <[_]>::copy_from_slice

Results from cargo +nightly bench --all-features:
https://gist.github.com/kinggoesgaming/25a5240ea8741524cdc8dc588ed6b046

Edit: Changes made here for reference https://github.com/uuid-rs/uuid/compare/copy-from-slice

So testing it, it seems our `copy_memory` function is faster than builtin `<[_]>::copy_from_slice` Results from `cargo +nightly bench --all-features`: https://gist.github.com/kinggoesgaming/25a5240ea8741524cdc8dc588ed6b046 Edit: Changes made here for reference https://github.com/uuid-rs/uuid/compare/copy-from-slice

KodrAus commented

2018-03-18 18:09:28 -05:00

(Migrated from github.com)