Delete copy_memory function #175

Merged

kinggoesgaming merged 1 commit from copy-from-slice into master

2018-03-19 06:59:20 -05:00

kinggoesgaming commented

2018-03-18 20:36:57 -05:00

(Migrated from github.com)

I'm submitting a ...

bug fix
feature enhancement
deprecation or removal
refactor

Description

Replace uuid::copy_memory with <[_]>::copy_from_slice

Motivation

core already provides a good optimized version of slice copying function, so we dont need to create our own duplicate code.

Tests

Our tests and benchmarks are running good, other than one or two runs which suggest a 1-2 nanosecond slowdown.

#173

**I'm submitting a ...** - [ ] bug fix - [ ] feature enhancement - [x] deprecation or removal - [x] refactor # Description Replace `uuid::copy_memory` with `<[_]>::copy_from_slice` # Motivation `core` already provides a good optimized version of `slice` copying function, so we dont need to create our own duplicate code. # Tests Our tests and benchmarks are running good, other than one or two runs which suggest a 1-2 nanosecond slowdown. # Related Issue(s) #173

radix (Migrated from github.com) reviewed

2018-03-18 20:36:57 -05:00

KodrAus (Migrated from github.com) reviewed

2018-03-18 20:36:57 -05:00

Dylan-DPC-zz commented

2018-03-19 06:51:49 -05:00

(Migrated from github.com)

bors: r+

Dylan-DPC-zz (Migrated from github.com) approved these changes

2018-03-19 06:52:02 -05:00

bors[bot] commented

2018-03-19 06:59:19 -05:00

(Migrated from github.com)

Build succeeded

# Build succeeded * [continuous-integration/appveyor/branch](https://ci.appveyor.com/project/KodrAus/uuid/build/1.0.250) * [continuous-integration/travis-ci/push](https://travis-ci.org/uuid-rs/uuid/builds/355323241?utm_source=github_status&utm_medium=notification)