gh-uuid-rs/uuid
Watch
1
0
Fork
You've already forked uuid
 0
Code Issues 10 Pull requests 2 Releases Activity

remove Uuid prefix #294

Merged
kinggoesgaming merged 5 commits from no-prefix into master 2018-08-14 03:16:15 -05:00
Conversation 11 Commits 5 Files changed 10 +201 -203
kinggoesgaming commented 2018-08-13 16:23:40 -05:00 (Migrated from github.com)

I'm submitting a(n) refactor

Description

It was discussed in the gitter chat that prefixing every data structure with Uuid is redundant.

**I'm submitting a(n)** refactor # Description It was discussed in the gitter chat that prefixing every data structure with `Uuid` is redundant.
radix (Migrated from github.com) reviewed 2018-08-13 16:23:40 -05:00
KodrAus (Migrated from github.com) reviewed 2018-08-13 16:23:40 -05:00
todo[bot] commented 2018-08-13 16:23:46 -05:00 (Migrated from github.com)

discuss to_ vs as_ vs into_

github.com/uuid-rs/uuid@cfaedf1fea/src/adapter/mod.rs (L73-L78)

This comment was generated by todo based on a TODO comment in cfaedf1fea in #294. cc @uuid-rs.
## discuss to_ vs as_ vs into_ https://github.com/uuid-rs/uuid/blob/cfaedf1fea0706dc0014b7ab56ef7ff85b3e96ac/src/adapter/mod.rs#L73-L78 --- ###### This comment was generated by [todo](https://todo.jasonet.co) based on a `TODO` comment in cfaedf1fea0706dc0014b7ab56ef7ff85b3e96ac in #294. cc @uuid-rs.
todo[bot] commented 2018-08-13 16:23:47 -05:00 (Migrated from github.com)

discuss rename to `from_slice`

github.com/uuid-rs/uuid@cfaedf1fea/src/lib.rs (L223-L228)

This comment was generated by todo based on a TODO comment in cfaedf1fea in #294. cc @uuid-rs.
## discuss rename to `from_slice` https://github.com/uuid-rs/uuid/blob/cfaedf1fea0706dc0014b7ab56ef7ff85b3e96ac/src/lib.rs#L223-L228 --- ###### This comment was generated by [todo](https://todo.jasonet.co) based on a `TODO` comment in cfaedf1fea0706dc0014b7ab56ef7ff85b3e96ac in #294. cc @uuid-rs.
todo[bot] commented 2018-08-13 16:32:03 -05:00 (Migrated from github.com)

discuss rename to `from_slice`

github.com/uuid-rs/uuid@9fb9b9e87a/src/lib.rs (L209-L214)

This comment was generated by todo based on a TODO comment in 9fb9b9e87a in #294. cc @uuid-rs.
## discuss rename to `from_slice` https://github.com/uuid-rs/uuid/blob/9fb9b9e87adab100bbaf157464f2eaa4f9034177/src/lib.rs#L209-L214 --- ###### This comment was generated by [todo](https://todo.jasonet.co) based on a `TODO` comment in 9fb9b9e87adab100bbaf157464f2eaa4f9034177 in #294. cc @uuid-rs.
todo[bot] commented 2018-08-13 18:46:53 -05:00 (Migrated from github.com)

discuss rename to `from_slice`

github.com/uuid-rs/uuid@b1107ce22e/src/lib.rs (L209-L214)

This comment was generated by todo based on a TODO comment in b1107ce22e in #294. cc @uuid-rs.
## discuss rename to `from_slice` https://github.com/uuid-rs/uuid/blob/b1107ce22ee9f45923b80490b0b54b606a0608f9/src/lib.rs#L209-L214 --- ###### This comment was generated by [todo](https://todo.jasonet.co) based on a `TODO` comment in b1107ce22ee9f45923b80490b0b54b606a0608f9 in #294. cc @uuid-rs.
todo[bot] commented 2018-08-13 19:12:42 -05:00 (Migrated from github.com)

discuss rename to `from_slice`

github.com/uuid-rs/uuid@96ae325545/src/lib.rs (L207-L212)

This comment was generated by todo based on a TODO comment in 96ae325545 in #294. cc @uuid-rs.
## discuss rename to `from_slice` https://github.com/uuid-rs/uuid/blob/96ae325545da6fac36b7fe692183f4ad209244cf/src/lib.rs#L207-L212 --- ###### This comment was generated by [todo](https://todo.jasonet.co) based on a `TODO` comment in 96ae325545da6fac36b7fe692183f4ad209244cf in #294. cc @uuid-rs.
Dylan-DPC-zz (Migrated from github.com) approved these changes 2018-08-14 02:20:03 -05:00
todo[bot] commented 2018-08-14 02:20:25 -05:00 (Migrated from github.com)

discuss rename to `from_slice`

github.com/uuid-rs/uuid@a262880bcb/src/lib.rs (L207-L212)

This comment was generated by todo based on a TODO comment in a262880bcb in #294. cc @uuid-rs.
## discuss rename to `from_slice` https://github.com/uuid-rs/uuid/blob/a262880bcb1ac22fc95323799d5721a9f1354792/src/lib.rs#L207-L212 --- ###### This comment was generated by [todo](https://todo.jasonet.co) based on a `TODO` comment in a262880bcb1ac22fc95323799d5721a9f1354792 in #294. cc @uuid-rs.
Dylan-DPC-zz commented 2018-08-14 03:08:52 -05:00 (Migrated from github.com)

bors: r+

bors: r+
bors[bot] commented 2018-08-14 03:16:14 -05:00 (Migrated from github.com)

Build succeeded

# Build succeeded * [continuous-integration/travis-ci/push](https://travis-ci.org/uuid-rs/uuid/builds/415807734?utm_source=github_status&utm_medium=notification) * [continuous-integration/appveyor/branch](https://ci.appveyor.com/project/KodrAus/uuid/build/1.0.856)
Sign in to join this conversation.
Reviewers
No reviewers
radix
KodrAus
Dylan-DPC-zz
Labels
Clear labels   
breaking
This causes a breaking change and will be merged to breaking branch.

  
bug

   
dependencies
Pull requests that update a dependency file

  
good first issue

   
help wanted

   
unstable
Tracking issue for an unstable optional dependency

No labels
breaking
bug
dependencies
good first issue
help wanted
unstable
Milestone
Clear milestone
No items
No milestone
0.7.0
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-uuid-rs/uuid!294
No description provided.