gh-uuid-rs/uuid
Watch
1
0
Fork
You've already forked uuid
 0
Code Issues 10 Pull requests 2 Releases Activity

bump rand to 0.4 #109

Closed
igor-raits wants to merge 1 commit from patch-1 into master
pull from: patch-1
merge into: gh-uuid-rs:master
Conversation 4 Commits 1 Files changed 1 +1 -1
igor-raits commented 2017-12-31 11:32:56 -06:00 (Migrated from github.com)
No description provided.
alexcrichton commented 2018-01-03 08:59:06 -06:00 (Migrated from github.com)

Thanks! Unfortunately rand is a public dependency, so I'm going to hold off on this until we have more breaking changes lined up for uuid

Thanks! Unfortunately `rand` is a public dependency, so I'm going to hold off on this until we have more breaking changes lined up for `uuid`
KodrAus (Migrated from github.com) approved these changes 2018-01-24 00:11:15 -06:00
KodrAus (Migrated from github.com) left a comment

Thanks @ignatenkobrain! We're thinking we'll remove rand as a public dependency of uuid for now so we can push towards releasing 1.0. We'll still need it as a private dependency though for the v4 feature so I think we could still merge this in.

Thanks @ignatenkobrain! We're thinking we'll remove `rand` as a public dependency of `uuid` for now so we can push towards releasing `1.0`. We'll still need it as a private dependency though for the `v4` feature so I think we could still merge this in.
KodrAus commented 2018-01-24 11:24:40 -06:00 (Migrated from github.com)

@ignatenkobrain Looks like there's a merge conflict here now. Would like to resolve this so I can merge, or would you rather close in favour of #112?

@ignatenkobrain Looks like there's a merge conflict here now. Would like to resolve this so I can merge, or would you rather close in favour of #112?
igor-raits commented 2018-01-24 15:45:40 -06:00 (Migrated from github.com)

So since #112 got merged, there is nothing left to do ;)

So since #112 got merged, there is nothing left to do ;)

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
KodrAus
Labels
Clear labels   
breaking
This causes a breaking change and will be merged to breaking branch.

  
bug

   
dependencies
Pull requests that update a dependency file

  
good first issue

   
help wanted

   
unstable
Tracking issue for an unstable optional dependency

No labels
breaking
bug
dependencies
good first issue
help wanted
unstable
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-uuid-rs/uuid!109
No description provided.