gh-uuid-rs/uuid
Watch
1
0
Fork
You've already forked uuid
 0
Code Issues 10 Pull requests 2 Releases Activity

Update sha1 to 0.5 #142

Merged
kinggoesgaming merged 1 commit from sha1-0_5 into master 2018-02-09 03:25:19 -06:00
Conversation 12 Commits 1 Files changed 1 +1 -1
kinggoesgaming commented 2018-02-08 14:15:38 -06:00 (Migrated from github.com)

closes #141

closes #141
Dylan-DPC-zz commented 2018-02-08 14:19:46 -06:00 (Migrated from github.com)

Kindly check if the repo has any breaking changes that affect us.

Kindly check if the repo has any breaking changes that affect us.
radix (Migrated from github.com) approved these changes 2018-02-08 15:20:00 -06:00
radix (Migrated from github.com) left a comment

It looks like sha1 did two things in 0.5:

  • add serde support (no effect on uuid)
  • bump rand to 0.4

The README for rand states that 0.4 "contains almost no breaking changes since the 0.3 release", and that it mostly just added new features.

It looks like sha1 did two things in 0.5: - add serde support (no effect on uuid) - bump rand to 0.4 The README for rand states that 0.4 "contains almost no breaking changes since the 0.3 release", and that it mostly just added new features.
kinggoesgaming commented 2018-02-08 21:01:17 -06:00 (Migrated from github.com)

I will check the changes in between the two versions of rand

I will check the changes in between the two versions of rand
KodrAus commented 2018-02-08 21:36:06 -06:00 (Migrated from github.com)

I think we're safe either way here, because sha1 isn't a public dependency.

I think we're safe either way here, because `sha1` isn't a public dependency.
KodrAus (Migrated from github.com) approved these changes 2018-02-08 21:36:21 -06:00
kinggoesgaming commented 2018-02-08 23:31:16 -06:00 (Migrated from github.com)

The only major one I see is the switch to JitterRNG for thread_local so this should be good

The only major one I see is the switch to `JitterRNG` for `thread_local` so this should be good
Dylan-DPC-zz (Migrated from github.com) approved these changes 2018-02-09 03:14:26 -06:00
Dylan-DPC-zz commented 2018-02-09 03:14:41 -06:00 (Migrated from github.com)

bors: r+

bors: r+
bors[bot] commented 2018-02-09 03:25:19 -06:00 (Migrated from github.com)

Build succeeded

# Build succeeded * [continuous-integration/appveyor/branch](https://ci.appveyor.com/project/KodrAus/uuid/build/1.0.101) * [continuous-integration/travis-ci/push](https://travis-ci.org/uuid-rs/uuid/builds/339369339?utm_source=github_status&utm_medium=notification)
igor-raits commented 2018-02-09 03:28:03 -06:00 (Migrated from github.com)

I actually thought that you would reuse serde feature ;)

I actually thought that you would reuse serde feature ;)
igor-raits commented 2018-02-09 03:29:13 -06:00 (Migrated from github.com)

Also it has std, so you at least should change std = [] → std = [sha1/std] or something like that

Also it has std, so you at least should change `std = []` → `std = [sha1/std]` or something like that
kinggoesgaming commented 2018-02-09 09:19:40 -06:00 (Migrated from github.com)

I can create a separate pr for that.. That was outside the scope of the issue

I can create a separate pr for that.. That was outside the scope of the issue
Sign in to join this conversation.
Reviewers
No reviewers
radix
KodrAus
Dylan-DPC-zz
Labels
Clear labels   
breaking
This causes a breaking change and will be merged to breaking branch.

  
bug

   
dependencies
Pull requests that update a dependency file

  
good first issue

   
help wanted

   
unstable
Tracking issue for an unstable optional dependency

No labels
breaking
bug
dependencies
good first issue
help wanted
unstable
Milestone
Clear milestone
No items
No milestone
0.6.0
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-uuid-rs/uuid!142
No description provided.