gh-uuid-rs/uuid

Watch

Fork 0

Add minimum supported rustc version #143

Merged

KodrAus merged 2 commits from min-supported-version into master

2018-02-09 09:37:39 -06:00

KodrAus commented

2018-02-08 21:42:20 -06:00

(Migrated from github.com)

Specifically test against rustc 1.18.0 so we know when we regress the minimum supported version. Personally, I'm ok with pushing the minimum version as a non-breaking change, but it's always good to know and communicate in the release notes.

Specifically test against `rustc 1.18.0` so we know when we regress the minimum supported version. Personally, I'm ok with pushing the minimum version as a non-breaking change, but it's always good to know and communicate in the release notes.

radix (Migrated from github.com) reviewed

2018-02-08 21:42:20 -06:00

kinggoesgaming commented

2018-02-08 23:01:49 -06:00

(Migrated from github.com)

Why did you specifically pick 1.18? Just curious

KodrAus commented

2018-02-08 23:49:15 -06:00

(Migrated from github.com)

It was a bit of an arbitrary decision, it's a release that I think most package managers support.

kinggoesgaming commented

2018-02-09 00:12:37 -06:00

(Migrated from github.com)

We need to check with some package managers before going for it, just to be sure

Dylan-DPC-zz commented

2018-02-09 00:15:39 -06:00

(Migrated from github.com)

1.18 is old enough for most crate owners to release a new version. I have seen a lot of crates keep 1.18 as their min dependency which is fine imo

kinggoesgaming (Migrated from github.com) approved these changes

2018-02-09 00:26:58 -06:00

kinggoesgaming (Migrated from github.com) left a comment

fair point. People using older versions should ideally update by now

Dylan-DPC-zz commented

2018-02-09 03:15:35 -06:00

(Migrated from github.com)

bors: r+

Dylan-DPC-zz commented

2018-02-09 09:25:01 -06:00

(Migrated from github.com)

bors: r+

kinggoesgaming commented

2018-02-09 09:25:56 -06:00

(Migrated from github.com)

bors: r+

bors[bot] commented

2018-02-09 09:25:56 -06:00

(Migrated from github.com)

Not awaiting review

kinggoesgaming commented

2018-02-09 09:26:43 -06:00

(Migrated from github.com)

bors r-

bors[bot] commented

2018-02-09 09:26:44 -06:00

(Migrated from github.com)

Canceled

# Canceled

Dylan-DPC-zz (Migrated from github.com) approved these changes

2018-02-09 09:31:29 -06:00

kinggoesgaming commented

2018-02-09 09:31:42 -06:00

(Migrated from github.com)

bors r+

bors[bot] commented

2018-02-09 09:37:39 -06:00

(Migrated from github.com)

Build succeeded

# Build succeeded * [continuous-integration/appveyor/branch](https://ci.appveyor.com/project/KodrAus/uuid/build/1.0.108) * [continuous-integration/travis-ci/push](https://travis-ci.org/uuid-rs/uuid/builds/339508889?utm_source=github_status&utm_medium=notification)